Review main Merged

73730[TASK] Update typo3/cms-styleguide

Stefan Bürk CR +2 V +2 Normal +31 −44 updated 02/27/22, 13:15

Commit message

Update styleguide to provide latest changes.

* ES6 modules and converted notification example #97006
* type=folder example #96983
* 'l10n_display' => 'defaultAsReadonly' example
* example for inline children with max_items set #91808
* inline symmetric with group field example

One of the styleguide changes adapted a table
name which is now longer. This leads to an edit
icon no longer being within view port. We fix
the chrome options and increase the browser
window size a bit - this gives a better overview
when looking an acceptance test screenshots, too.
This has minor impact on the page tree keyboard
test, too.

> composer u typo3/cms-styleguide

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 5

Review log 1421

  1. Stefan Bürk uploaded patch set 1 02/26/22, 21:11

  2. core-ci voted on patch set 1 V +1 02/26/22, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24344

  3. Stefan Bürk uploaded patch set 2 02/27/22, 10:30

  4. core-ci voted on patch set 2 V -1 02/27/22, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24353

  5. Stefan Bürk uploaded patch set 3 02/27/22, 10:55

  6. Stefan Bürk updated the commit message in patch set 4 02/27/22, 10:58

  7. Stefan Bürk updated the commit message in patch set 5 02/27/22, 10:58

  8. Benjamin Franzke updated the commit message in patch set 6 02/27/22, 10:59

  9. Benjamin Franzke updated the commit message in patch set 7 02/27/22, 11:00

  10. core-ci voted on patch set 7 V -1 02/27/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24359

  11. core-ci voted on patch set 3 V -1 02/27/22, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24355

  12. Christian Kuhn commented on patch set 7 CR -1 02/27/22, 11:20

    on it.
  13. Christian Kuhn uploaded patch set 8 02/27/22, 11:47

  14. Christian Kuhn uploaded patch set 9 02/27/22, 11:57

  15. core-ci voted on patch set 8 V -1 02/27/22, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24360

  16. core-ci voted on patch set 9 V -1 02/27/22, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24361

  17. Christian Kuhn uploaded patch set 10 02/27/22, 12:58

  18. core-ci voted on patch set 10 V +1 02/27/22, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24363

  19. Christian Kuhn voted on patch set 10 V +1 CR +1 02/27/22, 13:08

  20. Andreas Kienast voted on patch set 10 V +2 CR +2 02/27/22, 13:15

  21. Andreas Kienast merged patch set 11 02/27/22, 13:15