Review main Merged

73740[BUGFIX] Raise doctrine/lexer:"^1.2.3"

Stefan Bürk CR +2 V +2 Easy +10 −15 updated 03/01/22, 16:16

Commit message

doctrine/lexer has released a new minor version with
fixed method docblocks, thus phpstan ignore pattern
can now be removed again.

See: https://github.com/doctrine/lexer/issues/62

> composer req doctrine/lexer:"^1.2.3"
> composer req doctrine/lexer:"^1.2.3 \
  --no-update -d typo3/sysext/core
> Build/Scripts/runTests.sh \
  -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Stefan Bürk uploaded patch set 1 02/28/22, 20:52

  2. core-ci voted on patch set 1 V +1 02/28/22, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24393

  3. Oliver Klee voted on patch set 1 CR +1 02/28/22, 22:56

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/01/22, 07:45

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 03/01/22, 16:16

  6. Andreas Kienast merged patch set 2 03/01/22, 16:16