Review main Merged

73757[BUGFIX] Use proper flags for htmlspecialchars() in "View Documentation"

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 03/01/22, 21:25

Commit message

PHP8.1 changed the defaults for the second argument '$flags' from
'ENT_COMPAT' to 'ENT_QUOTES | ENT_SUBSTITUTE', which changes the
behaviour if that argument was not specified. In general this is a
good change, thus leaving it unspecified and live with the stricter
default was considered as the way to go in general.

However, in the specific case for rendering the ReST files of the
changelog and view it in the install tool this change now displays
weired and malformed documentation. To mitigate this, this patch
sets explicitly the second argument to 'ENT_COMPAT | ENT_SUBSTITUTE'
to restore the old behaviour but take malformed away for preparing
the documentation content.

See: https://github.com/php/php-src/blob/85b669e56583ee5d536168db7aaffbebe9d1aff2/UPGRADING#L166

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 914

  1. Stefan Bürk uploaded patch set 1 03/01/22, 20:40

  2. Stefan Bürk updated the commit message in patch set 2 03/01/22, 20:52

  3. Stefan Bürk updated the commit message in patch set 3 03/01/22, 20:52

  4. Oli Bartsch updated the commit message in patch set 4 03/01/22, 20:55

  5. Oli Bartsch commented on patch set 4 V +1 CR +1 03/01/22, 20:55

    Great, changelogs are readable again. :)
  6. core-ci voted on patch set 1 V +1 03/01/22, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24420

  7. core-ci voted on patch set 2 V +1 03/01/22, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24421

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 03/01/22, 21:03

  9. core-ci voted on patch set 3 V +1 03/01/22, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24422

  10. core-ci voted on patch set 4 V -1 03/01/22, 21:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24423

  11. core-ci voted on patch set 4 V +1 03/01/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24423

  12. Oli Bartsch voted on patch set 4 V +2 CR +2 03/01/22, 21:20

  13. Oli Bartsch merged patch set 5 03/01/22, 21:20

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 03/01/22, 21:25