Review main Merged

73760[TASK] Clean up CharsetConverter

Benni Mack CR +2 V +2 Hard +174 −204 updated 03/03/22, 09:03

Commit message

This change finalizes a long time of cleaning up
the main CharsetConverter class, whereas most
functionality is now internal and can use strict types
for their arguments, simplifying the code and return
types.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1218

  1. Benni Mack uploaded patch set 1 03/02/22, 08:26

  2. core-ci voted on patch set 1 V -1 03/02/22, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24436

  3. Benni Mack uploaded patch set 2 03/02/22, 08:53

  4. core-ci voted on patch set 2 V -1 03/02/22, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24438

  5. Benni Mack uploaded patch set 3 03/02/22, 09:18

  6. core-ci voted on patch set 3 V -1 03/02/22, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24440

  7. Benni Mack uploaded patch set 4 03/02/22, 13:39

  8. core-ci voted on patch set 4 V +1 03/02/22, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24462

  9. Oliver Klee voted on patch set 4 CR +1 03/02/22, 14:00

  10. Benni Mack uploaded patch set 5 03/02/22, 15:03

  11. core-ci voted on patch set 5 V -1 03/02/22, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24465

  12. Benni Mack uploaded patch set 6 03/02/22, 15:16

  13. core-ci voted on patch set 6 V +1 03/02/22, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24467

  14. Oliver Klee voted on patch set 6 CR +1 03/02/22, 17:14

  15. Christian Kuhn voted on patch set 6 V +1 CR +1 03/03/22, 08:31

  16. Stefan Bürk voted on patch set 6 V +1 CR +1 03/03/22, 08:41

  17. Benni Mack voted on patch set 6 V +2 CR +2 03/03/22, 09:03

  18. Benni Mack merged patch set 7 03/03/22, 09:03