73761[TASK] Add types to internal indexed_search code
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3043
Show 1018 earlier messages
-
Benni Mack uploaded patch set 1 03/02/22, 08:41
-
core-ci voted on patch set 1 V -1 03/02/22, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24437
-
Benni Mack rebased onto patch set 2 03/02/22, 16:16
-
core-ci voted on patch set 2 V -1 03/02/22, 16:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24472
-
Benni Mack uploaded patch set 3 03/02/22, 20:22
-
core-ci voted on patch set 3 V -1 03/02/22, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24478
-
Benni Mack uploaded patch set 4 03/02/22, 21:16
-
core-ci voted on patch set 4 V -1 03/02/22, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24480
-
Benni Mack uploaded patch set 5 03/07/22, 20:59
-
core-ci voted on patch set 5 V -1 03/07/22, 21:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24691
-
Benni Mack rebased onto patch set 6 04/17/22, 20:25
-
core-ci voted on patch set 6 V -1 04/17/22, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26122
-
core-ci commented on patch set 6 04/17/22, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26122
-
Stefan Bürk commented on patch set 6 CR -1 04/17/22, 22:16
on itIndexSearchRepository.php:164needs (int) cast hereIndexSearchRepository.php:166(bool) cast should be added here too -
Stefan Bürk uploaded patch set 7 04/17/22, 22:22
-
Stefan Bürk commented on patch set 7 04/17/22, 22:22
IndexSearchRepository.php:164ReplyDoneIndexSearchRepository.php:166ReplyDone -
Stefan Bürk wrote 04/17/22, 22:30
Removed reviewer Stefan Bürk. -
core-ci voted on patch set 7 V +1 04/17/22, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26127
-
Benni Mack updated the commit message in patch set 8 04/17/22, 22:47
-
Benni Mack commented on patch set 8 04/17/22, 22:48
Thanks, Stefan! -
core-ci voted on patch set 8 V +1 04/17/22, 22:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26129
-
Oliver Klee commented on patch set 8 04/18/22, 09:05
IndexSearchRepository.php:85This should be initialized with a value (e.g., false) to make sure the object is valid directly after contruction. (Relying on the initialize call seems a bit risky to me, and static code analysis also cannot know this.)IndexSearchRepository.php:180We can add the return types here.IndexSearchRepository.php:276We can add the return types here.IndexSearchRepository.php:301We can add the return types here.IndexSearchRepository.php:412We can add the return types here.IndexSearchRepository.php:626We can add the return types here.IndexSearchRepository.php:652We can add the return types here.IndexSearchRepository.php:670We can add the return types here.IndexSearchRepository.php:686We can add the return types here (and for all other methods).IndexedSearchUtility.php:40Please let's make the check more explicit (without implicit type casts): $tableList !== ''IndexedSearchUtility.php:154string $operator -
Stefan Bürk commented on patch set 8 CR -1 04/18/22, 09:07
on it -
Stefan Bürk uploaded patch set 9 04/18/22, 10:44
-
Stefan Bürk commented on patch set 8 CR 0 04/18/22, 10:44
IndexSearchRepository.php:85ReplyDoneIndexSearchRepository.php:180ReplyDoneIndexSearchRepository.php:276ReplyDoneIndexSearchRepository.php:301ReplyDoneIndexSearchRepository.php:412ReplyDoneIndexSearchRepository.php:626ReplyDoneIndexSearchRepository.php:652ReplyDoneIndexSearchRepository.php:670ReplyDoneIndexSearchRepository.php:686ReplyDoneIndexedSearchUtility.php:40ReplyDoneIndexedSearchUtility.php:154ReplyDone -
Oliver Klee voted on patch set 9 CR +1 04/18/22, 11:03
-
core-ci voted on patch set 9 V +1 04/18/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26139
-
Stefan Bürk rebased onto patch set 10 04/20/22, 00:55
-
core-ci voted on patch set 10 V +1 04/20/22, 01:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26212
-
Stefan Bürk voted on patch set 10 V +1 CR +1 04/20/22, 01:17
-
Oliver Klee voted on patch set 10 CR +1 04/20/22, 07:13
-
Oli Bartsch commented on patch set 10 04/20/22, 08:43
IndexSearchRepository.php:127Is this a leftover or intended?IndexSearchRepository.php:486Type cast is redundantIndexSearchRepository.php:573This should be casted to string now. $indexerObj->metaphone() currently returns "int|mixed".IndexSearchRepository.php:1187Could we get rid of this wrapper?IndexSearchRepository.php:1200Could we get rid of this wrapper?IndexSearchRepository.php:1255Return type missing?IndexedSearchUtility.php:74Do we need to typecast this or are we sure $val will always be a string?IndexedSearchUtility.php:99Return type missing? -
Stefan Bürk voted on patch set 10 V 0 CR 0 04/20/22, 08:45
-
Oliver Klee voted on patch set 10 CR 0 04/20/22, 09:28
-
Stefan Bürk uploaded patch set 11 04/22/22, 14:24
-
Stefan Bürk commented on patch set 10 04/22/22, 14:25
IndexSearchRepository.php:127ReplyDoneIndexSearchRepository.php:486ReplyDoneIndexSearchRepository.php:573ReplyDoneIndexSearchRepository.php:1187ReplyDoneIndexSearchRepository.php:1200ReplyDoneIndexSearchRepository.php:1255ReplyDoneIndexedSearchUtility.php:74ReplyAdded two string cast in the split method, and adjusted the doctype. So it's ensured now. (and should have been before). Would this be fine with you ?IndexedSearchUtility.php:99ReplyDone -
core-ci voted on patch set 11 V +1 04/22/22, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26305
-
Oli Bartsch uploaded patch set 12 04/22/22, 17:24
-
Oli Bartsch commented on patch set 12 V +1 CR +1 04/22/22, 17:24
IndexedSearchUtility.php:74ReplyDone -
Stefan Bürk voted on patch set 12 V +1 CR +1 04/22/22, 17:25
-
core-ci voted on patch set 12 V +1 04/22/22, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/26312
-
Oli Bartsch voted on patch set 12 V +2 CR +2 04/22/22, 17:48
-
Oli Bartsch merged patch set 13 04/22/22, 17:48