Review main Merged

73762[TASK] Move TS condition check to TS condition matcher

Helmut Hummel CR +2 V +2 Normal +24 −32 updated 03/05/22, 20:32

Commit message

The ExpressionLanguageResolver should be generic and not
implement some TypoScript related logic.

Therefore the check for "ELSE" expression is moved to
AbstractConditionMatcher

Dead code is removed on the go.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Torben Hansen +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Torben Hansen +1
    • Benni Mack +1

Issues 1

Files 5

Review log 911

  1. Helmut Hummel uploaded patch set 1 03/02/22, 09:11

  2. core-ci voted on patch set 1 V -1 03/02/22, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24439

  3. Helmut Hummel uploaded patch set 2 03/02/22, 11:09

  4. Helmut Hummel rebased onto patch set 3 03/02/22, 11:09

  5. core-ci voted on patch set 2 V +1 03/02/22, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24445

  6. Torben Hansen voted on patch set 3 CR +1 03/02/22, 11:47

  7. Benni Mack voted on patch set 3 CR +1 03/02/22, 15:17

  8. Benni Mack voted on patch set 3 V +1 03/02/22, 15:17

  9. Torben Hansen voted on patch set 3 V +1 03/02/22, 15:22

  10. Helmut Hummel voted on patch set 3 V +2 CR +2 03/05/22, 20:31

  11. Helmut Hummel merged patch set 4 03/05/22, 20:32