73762[TASK] Move TS condition check to TS condition matcher
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Torben Hansen +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Torben Hansen +1
- Benni Mack +1
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php+7 −4
- typo3/sysext/core/Classes/ExpressionLanguage/Resolver.php+0 −6
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+14 −0
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+3 −17
Review log 911
-
Helmut Hummel uploaded patch set 1 03/02/22, 09:11
-
core-ci voted on patch set 1 V -1 03/02/22, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24439
-
Helmut Hummel uploaded patch set 2 03/02/22, 11:09
-
Helmut Hummel rebased onto patch set 3 03/02/22, 11:09
-
core-ci voted on patch set 2 V +1 03/02/22, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24445
-
Torben Hansen voted on patch set 3 CR +1 03/02/22, 11:47
-
Benni Mack voted on patch set 3 CR +1 03/02/22, 15:17
-
Benni Mack voted on patch set 3 V +1 03/02/22, 15:17
-
Torben Hansen voted on patch set 3 V +1 03/02/22, 15:22
-
Helmut Hummel voted on patch set 3 V +2 CR +2 03/05/22, 20:31
-
Helmut Hummel merged patch set 4 03/05/22, 20:32