Review main Abandoned

73763[TASK] Clean up baseline for phpstan

Benni Mack CR 0 V 0 Easy +0 −30 updated 03/02/22, 14:06

Commit message

Due to an update, some ignored errors
in the baseline file of PHPStan plus the
merge of #97053 this change cleans up
the now removed ignored errors.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 03/02/22, 09:29

  2. Benni Mack updated the commit message in patch set 2 03/02/22, 09:30

  3. Oliver Klee voted on patch set 2 CR +1 03/02/22, 09:31

  4. core-ci voted on patch set 1 V -1 03/02/22, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24441

  5. core-ci voted on patch set 2 V -1 03/02/22, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24442

  6. Christian Kuhn commented on patch set 2 03/02/22, 09:43

    baseline green for me without patch. sure your're running current main?
  7. Oliver Klee voted on patch set 2 CR -1 03/02/22, 10:21

  8. Benni Mack abandoned the change 03/02/22, 14:06

    not needed anymore