Review main Merged

73765[TASK] Provide forward-compatible CompositeExpression/ExpressionBuilder

Stefan Bürk CR +2 V +2 Normal +158 −18 updated 03/04/22, 17:40

Commit message

doctrine/dbal changed their API and usage for CompositeExpression
and ExpressionBuilder with 4.0, which they already deprecated in
3.x.

To avoid a big drift over time core has to follow these changes
in the provided facade implementations, but keep the
core promises up. Furthermore this paves the way to be able to
raise doctrine/dbal:^4.0 later without being breaking. At least
this is one preparation for this goal, not the last.

To give extension developers the ability to support their extensions
for two core versions without doing dirty hacks to avoid deprecation
messages spammed into the logs, this patch provides the new methods
as a forward-compatible backport change. Core usages and the finally
deprecation will be done in dedicated follow up patches for the
main branch.

This patch provides following new methods:

* static 'CompositeExpression::and()' and 'or()' as drop-in
  replacement for 'new CompositeExpress( $type , array $parts)',
  where $type is 'and' or 'or'
* 'ExpressionBuilder::and()' as drop-in replacement for 'andX()'
* 'ExpressionBuilder::or()' as drop-in replacement for 'orX()'

Argument types of the new methods will be made strict with the
following deprecation patch as union types are not supported
by all required PHP versions for v11.5.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1729

Show 34 earlier messages
  1. Stefan Bürk uploaded patch set 1 03/02/22, 11:23

  2. core-ci voted on patch set 1 V -1 03/02/22, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24449

  3. Stefan Bürk uploaded patch set 2 03/02/22, 11:41

  4. Stefan Bürk uploaded patch set 3 03/02/22, 11:45

  1. Stefan Bürk uploaded patch set 4 03/02/22, 11:49

  2. Stefan Bürk uploaded patch set 5 03/02/22, 11:55

  3. core-ci voted on patch set 2 V +1 03/02/22, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24450

  4. core-ci voted on patch set 4 V -1 03/02/22, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24451

  5. core-ci voted on patch set 5 V +1 03/02/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24452

  6. Stefan Bürk uploaded patch set 6 03/02/22, 12:09

  7. core-ci voted on patch set 6 V -1 03/02/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24453

  8. Stefan Bürk uploaded patch set 7 03/02/22, 12:22

  9. Stefan Bürk uploaded patch set 8 03/02/22, 12:26

  10. core-ci voted on patch set 7 V +1 03/02/22, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24454

  11. core-ci voted on patch set 8 V +1 03/02/22, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24455

  12. Stefan Bürk updated the commit message in patch set 9 03/02/22, 12:42

  13. core-ci voted on patch set 9 V +1 03/02/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24456

  14. Stefan Bürk commented on patch set 9 03/02/22, 13:08

  15. Oliver Klee updated the commit message in patch set 10 03/02/22, 13:12

  16. core-ci voted on patch set 10 V +1 03/02/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24459

  17. core-ci voted on patch set 9 V +1 03/02/22, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24458

  18. Stefan Bürk updated the commit message in patch set 11 03/02/22, 13:39

  19. core-ci voted on patch set 11 V +1 03/02/22, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24461

  20. Stefan Bürk commented on patch set 11 03/02/22, 15:19

    Reply

    nightly green.
  21. Benni Mack updated the commit message in patch set 12 03/02/22, 15:20

  22. core-ci voted on patch set 12 V +1 03/02/22, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24468

  23. Benni Mack voted on patch set 12 V +1 CR +1 03/03/22, 07:23

  24. Christian Kuhn voted on patch set 12 V +2 CR +2 03/04/22, 17:40

  25. Christian Kuhn merged patch set 13 03/04/22, 17:40