73766[TASK] Provide forward-compatible CompositeExpression/ExpressionBuilder
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 3
Review log 1015
-
Stefan Bürk uploaded patch set 1 03/02/22, 12:57
-
core-ci voted on patch set 1 V +1 03/02/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24457
-
Oliver Klee updated the commit message in patch set 2 03/02/22, 13:12
-
Stefan Bürk updated the commit message in patch set 3 03/02/22, 13:39
-
Stefan Bürk commented on patch set 3 03/02/22, 14:10
Backport notes: ``` Kept docblock argument types from v11 for: * ExpressionBuilder::andX(...) * ExpressionBuilder::orX(...) but added "@see" lines to add a first awareness for the new methods ``` -
Stefan Bürk commented on patch set 3 03/02/22, 14:12
Reply
Additional notes: * patchset 2 failed to trigger a pipeline run, so no vote. * patchset 3 triggered pipeline run, which was green. but vote got lost. However started a nightly run on patchset 3: https://git.typo3.org/typo3/CI/cms/-/pipelines/24463 -
core-ci voted on patch set 3 V -1 03/02/22, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24463
-
core-ci voted on patch set 3 V +1 03/02/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24463
-
Stefan Bürk commented on patch set 3 03/02/22, 15:00
Reply
First nightly failure was a acceptance hickup :/ -
Stefan Bürk updated the commit message in patch set 4 03/02/22, 15:34
-
core-ci voted on patch set 4 V +1 03/02/22, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24470
-
Christian Kuhn rebased onto patch set 5 03/04/22, 21:01
-
core-ci voted on patch set 5 V +1 03/04/22, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24593
-
Christian Kuhn voted on patch set 5 V +2 CR +2 03/04/22, 21:18
-
Christian Kuhn merged patch set 6 03/04/22, 21:18