Review main Merged

73767[TASK] Add request tests for DELETE,PATCH,PUT AND POST with data

Stefan Bürk CR +2 V +2 Hard +337 −1 updated 03/04/22, 19:11

Commit message

The testing-framework with FE requests using sub requests
is now able to handle DELETE,PATCH,PUT and POST requests.

The situation in testing-framework is not the final solution,
though. The patch adds a test to verify if testing-framework
request details are properly received in the FE application.

This not only adds a use case to the core for these kind
of requests, but also ensures that we don't break this
detail again when testing-framework internal handling is
further refactored.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1118

  1. Stefan Bürk uploaded patch set 1 03/03/22, 00:06

  2. Stefan Bürk uploaded patch set 2 03/03/22, 00:12

  3. core-ci voted on patch set 1 V -1 03/03/22, 00:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24482

  4. Stefan Bürk uploaded patch set 3 03/03/22, 00:22

  5. core-ci voted on patch set 2 V -1 03/03/22, 00:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24483

  6. core-ci voted on patch set 3 V +1 03/03/22, 00:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24484

  7. Stefan Bürk uploaded patch set 4 03/04/22, 17:51

  8. core-ci voted on patch set 4 V +1 03/04/22, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24573

  9. Christian Kuhn uploaded patch set 5 03/04/22, 18:12

  10. Oliver Klee updated the commit message in patch set 6 03/04/22, 18:12

  11. Christian Kuhn uploaded patch set 7 03/04/22, 18:15

  12. Christian Kuhn uploaded patch set 8 03/04/22, 18:17

  13. core-ci voted on patch set 5 V -1 03/04/22, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24575

  14. core-ci voted on patch set 6 V -1 03/04/22, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24576

  15. core-ci voted on patch set 8 V +1 03/04/22, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24578

  16. Christian Kuhn voted on patch set 8 V +1 CR +1 03/04/22, 18:59

  17. Anja Leichsenring voted on patch set 8 V +2 CR +2 03/04/22, 19:11

  18. Anja Leichsenring merged patch set 9 03/04/22, 19:11