Review 11.5 Merged

73768[TASK] Add request tests for DELETE,PATCH,PUT AND POST with data

Stefan Bürk CR +2 V +2 Hard +345 −9 updated 03/04/22, 20:58

Commit message

The testing-framework with FE requests using sub requests
is now able to handle DELETE,PATCH,PUT and POST requests.

The situation in testing-framework is not the final solution,
though. The patch adds a test to verify if testing-framework
request details are properly received in the FE application.

This not only adds a use case to the core for these kind
of requests, but also ensures that we don't break this
detail again when testing-framework internal handling is
further refactored.

Also needs a testing-framework bugfix in v11:
> composer req --dev typo3/testing-framework:^6.16.2

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 1221

  1. Stefan Bürk uploaded patch set 1 03/03/22, 00:33

  2. core-ci voted on patch set 1 V -1 03/03/22, 00:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24485

  3. Stefan Bürk uploaded patch set 2 03/03/22, 06:48

  4. core-ci voted on patch set 2 V -1 03/03/22, 07:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24489

  5. Stefan Bürk uploaded patch set 3 03/03/22, 07:33

  6. core-ci voted on patch set 3 V +1 03/03/22, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24492

  7. Stefan Bürk uploaded patch set 4 03/04/22, 17:54

  8. core-ci voted on patch set 4 V +1 03/04/22, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24574

  9. Christian Kuhn commented on patch set 4 CR -1 03/04/22, 19:00

    needs a fresh backport when main is merged.
  10. Christian Kuhn uploaded patch set 5 03/04/22, 19:18

  11. Christian Kuhn uploaded patch set 6 03/04/22, 19:19

  12. core-ci voted on patch set 5 V -1 03/04/22, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24581

  13. core-ci voted on patch set 6 V -1 03/04/22, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24582

  14. Stefan Bürk uploaded patch set 7 03/04/22, 19:36

  15. core-ci voted on patch set 7 V -1 03/04/22, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24584

  16. Stefan Bürk uploaded patch set 8 03/04/22, 20:24

  17. core-ci voted on patch set 8 V +1 03/04/22, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24587

  18. Christian Kuhn uploaded patch set 9 03/04/22, 20:41

  19. core-ci voted on patch set 9 V +1 03/04/22, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24590

  20. Christian Kuhn voted on patch set 9 V +2 CR +2 03/04/22, 20:58

  21. Christian Kuhn merged patch set 10 03/04/22, 20:58