Review main Merged Breaking

73770[!!!][TASK] Remove CLI commands related to uploads/ folder

Benni Mack CR +2 V +2 Hard +45 −870 updated 03/07/22, 21:20

Commit message

A few leftover code pieces including the CLI commands have
been removed.

 * cleanup:multiplereferencedfiles
 * cleanup:lostfiles
 * cleanup:missingfiles

The uploads/ folder functionality has been removed
in TYPO3 v10. Thus, the commands have no use anymore,
and are removed as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1115

  1. Benni Mack uploaded patch set 1 03/03/22, 08:36

  2. core-ci voted on patch set 1 V -1 03/03/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24496

  3. Benni Mack uploaded patch set 2 03/07/22, 16:03

  4. core-ci voted on patch set 2 V +1 03/07/22, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24668

  5. Benni Mack uploaded patch set 3 03/07/22, 17:04

  6. core-ci voted on patch set 3 V +1 03/07/22, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24669

  7. Oliver Klee commented on patch set 3 CR -1 03/07/22, 17:37

    This sentence seems to be cut off in the middle.
  8. Benni Mack updated the commit message in patch set 4 03/07/22, 18:27

  9. Benni Mack commented on patch set 4 03/07/22, 18:27

    Thanks!

    Reply

    Done
  10. Oliver Klee wrote 03/07/22, 18:29

    Removed reviewer Oliver Klee.
  11. core-ci voted on patch set 4 V +1 03/07/22, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24681

  12. Georg Ringer voted on patch set 4 V +1 CR +1 03/07/22, 21:01

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 03/07/22, 21:10

  14. Benni Mack voted on patch set 4 V +2 CR +2 03/07/22, 21:20

  15. Benni Mack merged patch set 5 03/07/22, 21:20