Review main Merged

73771[BUGFIX] Set pid in AddController for new records

Susi Moog CR +2 V +2 Easy +2 −1 updated 03/04/22, 20:38

Commit message

Fixes an exception thrown when creating a backend
user group for a new user.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Susi Moog uploaded patch set 1 03/03/22, 08:41

  2. Susi Moog commented on patch set 1 03/03/22, 08:42

    If anyone has an idea on how that part of the code is supposed to look like, please help out ;)
  3. core-ci voted on patch set 1 V +1 03/03/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24498

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 03/04/22, 14:49

  5. Oli Bartsch commented on patch set 1 CR -1 03/04/22, 15:37

    AddController.php:231

    Looking at https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php#L76, this seems to be never set. It's also not used elsewhere in this class.
  6. Christian Kuhn uploaded patch set 2 03/04/22, 19:55

  7. Christian Kuhn commented on patch set 2 03/04/22, 19:56

    AddController.php:231 Reply

    not 100% sure, but it looks as if you're correct. I'd say: go with your suggestion in v12, but be more conservative in v11 with keeping it.
  8. core-ci voted on patch set 2 V +1 03/04/22, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24585

  9. Christian Kuhn commented on patch set 2 03/04/22, 20:35

    AddController.php:231

    all that is not safe. but it should be ok as a bug fix for now.
  10. Stefan Bürk commented on patch set 2 03/04/22, 20:35

    AddController.php:231 Reply

    Ack to both. Use the suggestion in v12, but be conservative in the backport.
  11. Stefan Bürk voted on patch set 2 V +1 CR +1 03/04/22, 20:35

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 03/04/22, 20:38

  13. Christian Kuhn merged patch set 3 03/04/22, 20:38