73771[BUGFIX] Set pid in AddController for new records
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1113
-
Susi Moog uploaded patch set 1 03/03/22, 08:41
-
Susi Moog commented on patch set 1 03/03/22, 08:42
If anyone has an idea on how that part of the code is supposed to look like, please help out ;) -
core-ci voted on patch set 1 V +1 03/03/22, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24498
-
Christian Kuhn voted on patch set 1 V +1 CR +1 03/04/22, 14:49
-
Oli Bartsch commented on patch set 1 CR -1 03/04/22, 15:37
AddController.php:231Looking at https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php#L76, this seems to be never set. It's also not used elsewhere in this class. -
Christian Kuhn uploaded patch set 2 03/04/22, 19:55
-
Christian Kuhn commented on patch set 2 03/04/22, 19:56
AddController.php:231Replynot 100% sure, but it looks as if you're correct. I'd say: go with your suggestion in v12, but be more conservative in v11 with keeping it. -
core-ci voted on patch set 2 V +1 03/04/22, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24585
-
Christian Kuhn commented on patch set 2 03/04/22, 20:35
AddController.php:231all that is not safe. but it should be ok as a bug fix for now. -
Stefan Bürk commented on patch set 2 03/04/22, 20:35
AddController.php:231ReplyAck to both. Use the suggestion in v12, but be conservative in the backport. -
Stefan Bürk voted on patch set 2 V +1 CR +1 03/04/22, 20:35
-
Christian Kuhn voted on patch set 2 V +2 CR +2 03/04/22, 20:38
-
Christian Kuhn merged patch set 3 03/04/22, 20:38