73792[TASK] Refactor be user access check in TSFE
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97091-TSFE-clear_previewHasBeenRemoved.rstnew+41 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php5+8 −91
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+42 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1420
-
Susi Moog uploaded patch set 1 03/03/22, 10:03
-
Susi Moog marked it work in progress 03/03/22, 10:04
-
Susi Moog commented on patch set 1 03/03/22, 10:04
This change is ready for review. -
Susi Moog marked it work in progress 03/03/22, 10:04
-
core-ci voted on patch set 1 V -1 03/03/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24501
-
Susi Moog uploaded patch set 2 03/03/22, 11:03
-
core-ci voted on patch set 2 V -1 03/03/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24504
-
Benni Mack commented on patch set 2 03/03/22, 11:18
TypoScriptFrontendController.php:644this method can now be removed (thank god!)TypoScriptFrontendController.php:727let's add a todo to move this to the TypoScripFrontendInitializtion middleware in the next step. -
Susi Moog uploaded patch set 3 03/03/22, 12:28
-
Susi Moog commented on patch set 3 03/03/22, 12:33
This change is ready for review.TypoScriptFrontendController.php:644ReplyDoneTypoScriptFrontendController.php:727ReplyDone -
Susi Moog updated the commit message in patch set 4 03/03/22, 12:34
-
Susi Moog updated the commit message in patch set 5 03/03/22, 12:34
-
core-ci voted on patch set 3 V -1 03/03/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24508
-
core-ci voted on patch set 4 V -1 03/03/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24510
-
core-ci voted on patch set 5 V -1 03/03/22, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24511
-
Susi Moog uploaded patch set 6 03/03/22, 13:16
-
core-ci voted on patch set 6 V +1 03/03/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24516
-
Benni Mack voted on patch set 6 V +1 CR +1 03/03/22, 13:49
-
Christian Kuhn commented on patch set 6 V +2 CR +2 03/05/22, 20:34
TypoScriptFrontendController.php:657that was true PITA. thx! -
Christian Kuhn merged patch set 7 03/05/22, 20:35