Review main Merged

73792[TASK] Refactor be user access check in TSFE

Susi Moog CR +2 V +2 Normal +98 −93 updated 03/05/22, 20:35

Commit message

Instead of "pretending" no backend user is logged in and
fetching the page as if nothing happened, the pageNotFound
handling is utilized to handle the case of having a valid
backend user theoretically being able to preview pages
without access to the specific page that is being called.

This avoids unsetting the backend user and re-fetching the
page and keeps the rendering in the users' context - additionally,
all preview related settings are now centrally handled in the
PreviewSimulator.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1420

  1. Susi Moog uploaded patch set 1 03/03/22, 10:03

  2. Susi Moog marked it work in progress 03/03/22, 10:04

  3. Susi Moog commented on patch set 1 03/03/22, 10:04

    This change is ready for review.
  4. Susi Moog marked it work in progress 03/03/22, 10:04

  5. core-ci voted on patch set 1 V -1 03/03/22, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24501

  6. Susi Moog uploaded patch set 2 03/03/22, 11:03

  7. core-ci voted on patch set 2 V -1 03/03/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24504

  8. Benni Mack commented on patch set 2 03/03/22, 11:18

    TypoScriptFrontendController.php:644

    this method can now be removed (thank god!)

    TypoScriptFrontendController.php:727

    let's add a todo to move this to the TypoScripFrontendInitializtion middleware in the next step.
  9. Susi Moog uploaded patch set 3 03/03/22, 12:28

  10. Susi Moog commented on patch set 3 03/03/22, 12:33

    This change is ready for review.

    TypoScriptFrontendController.php:644 Reply

    Done

    TypoScriptFrontendController.php:727 Reply

    Done
  11. Susi Moog updated the commit message in patch set 4 03/03/22, 12:34

  12. Susi Moog updated the commit message in patch set 5 03/03/22, 12:34

  13. core-ci voted on patch set 3 V -1 03/03/22, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24508

  14. core-ci voted on patch set 4 V -1 03/03/22, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24510

  15. core-ci voted on patch set 5 V -1 03/03/22, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24511

  16. Susi Moog uploaded patch set 6 03/03/22, 13:16

  17. core-ci voted on patch set 6 V +1 03/03/22, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24516

  18. Benni Mack voted on patch set 6 V +1 CR +1 03/03/22, 13:49

  19. Christian Kuhn commented on patch set 6 V +2 CR +2 03/05/22, 20:34

    TypoScriptFrontendController.php:657

    that was true PITA. thx!
  20. Christian Kuhn merged patch set 7 03/05/22, 20:35