Review main Merged

73796[BUGFIX] Fix PHP 8.0 warning with inline sychronize

Christian Kuhn CR +2 V +2 Normal +192 −6 updated 03/03/22, 22:14

Commit message

Scenario:
* Add a content element with an image in default language.
* Translate the content element to some other language,
  this will create the image in the localized element, too.
* Edit the default language element and add another image.
* Edit the localized element, see the 'shadowed' new image,
  click "localize" button on the right.
-> Red error pop up, logged warning: "Array to string
conversion" in FormInlineAjaxController.php

The patch fixes this, and adds two acceptance tests to
have a basic coverage for the new content element wizard,
the element browser inline image selection, and the
localization 'synchronize' process.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Christian Kuhn uploaded patch set 1 03/03/22, 12:21

  2. Benni Mack commented on patch set 1 03/03/22, 12:25

    "Fix PHP 8.0 warning..."
  3. core-ci voted on patch set 1 V -1 03/03/22, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24507

  4. Christian Kuhn uploaded patch set 2 03/03/22, 12:33

  5. Christian Kuhn updated the commit message in patch set 3 03/03/22, 12:34

  6. Christian Kuhn commented on patch set 3 03/03/22, 12:34

    Reply

    Done
  7. Christian Kuhn uploaded patch set 4 03/03/22, 12:36

  8. core-ci voted on patch set 4 V +1 03/03/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24513

  9. core-ci voted on patch set 2 V +1 03/03/22, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24509

  10. core-ci voted on patch set 3 V -1 03/03/22, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24512

  11. Stefan Bürk commented on patch set 4 V +1 CR +1 03/03/22, 13:14

    patchset 3 had postgres / openssl issue. restarted it and pipeline green - ci revote lost in space ....
  12. Benni Mack voted on patch set 4 V +1 CR +1 03/03/22, 13:19

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 03/03/22, 22:14

  14. Christian Kuhn merged patch set 5 03/03/22, 22:14