Review main Merged

73798[FEATURE] Allow non-namespaced arguments in extbase backend modules

Susi Moog CR +2 V +2 Hard +168 −90 updated 03/07/22, 20:06

Commit message

Extbase modules traditionally use the plugin or module namespace
to prefix get parameters and map arguments to plugins. In the
frontend context, this makes sense, as multiple plugins may reside
on a page. In the backend, however, an extbase module is responsible
for rendering a complete view.
Therefore the namespacing of arguments can be disabled, making URLs
easier to read, more in line with non-extbase modules and allowing
extbase modules to directly access outside information like the "id"
parameter handed over by the page tree for example.

To allow extbase modules to configure this behaviour, a feature flag
can be set in the module configuration turning the namespacing off or on.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 2742

Show 1017 earlier messages
  1. Susi Moog uploaded patch set 1 03/03/22, 14:04

  2. core-ci voted on patch set 1 V -1 03/03/22, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24517

  3. Susi Moog uploaded patch set 2 03/03/22, 15:30

  4. core-ci voted on patch set 2 V -1 03/03/22, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24520

  5. Susi Moog uploaded patch set 3 03/03/22, 15:50

  6. core-ci voted on patch set 3 V -1 03/03/22, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24521

  7. Susi Moog uploaded patch set 4 03/03/22, 17:32

  8. Susi Moog updated the commit message in patch set 5 03/04/22, 08:10

  9. core-ci voted on patch set 5 V -1 03/04/22, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24541

  10. Susi Moog uploaded patch set 6 03/04/22, 08:25

  11. core-ci voted on patch set 6 V +1 03/04/22, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24542

  12. Susi Moog updated the commit message in patch set 7 03/04/22, 09:26

  13. Susi Moog marked it ready for review 03/04/22, 09:26

  14. Benni Mack uploaded patch set 8 03/04/22, 10:09

  15. core-ci voted on patch set 8 V -1 03/04/22, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24545

  16. Benni Mack uploaded patch set 9 03/04/22, 11:21

  17. core-ci voted on patch set 9 V -1 03/04/22, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24551

  1. Benni Mack uploaded patch set 10 03/04/22, 12:43

  2. core-ci voted on patch set 10 V -1 03/04/22, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24553

  3. Benni Mack uploaded patch set 11 03/04/22, 15:37

  4. Benni Mack uploaded patch set 12 03/04/22, 15:43

  5. Benni Mack voted on patch set 12 V +1 CR +1 03/04/22, 15:43

  6. Oli Bartsch commented on patch set 12 03/04/22, 15:53

    BackendUserController.php:178

    So, existing shortcut button do no longer work.

    ext_typoscript_setup.typoscript:14

    Indentation could be fixed here
  7. core-ci voted on patch set 11 V -1 03/04/22, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24565

  8. core-ci voted on patch set 12 V -1 03/04/22, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24567

  9. Benni Mack uploaded patch set 13 03/04/22, 16:19

  10. Benni Mack commented on patch set 13 03/04/22, 16:19

    BackendUserController.php:178 Reply

    Yes. However, as we're working on improving backend modules in general, I think we need one final upgrade wizard regarding shortcuts once we're done here.

    ext_typoscript_setup.typoscript:14 Reply

    Done
  11. Benni Mack rebased onto patch set 14 03/04/22, 18:49

  12. core-ci voted on patch set 14 V -1 03/04/22, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24579

  13. Benni Mack uploaded patch set 15 03/07/22, 14:33

  14. Benni Mack uploaded patch set 16 03/07/22, 14:34

  15. Benni Mack uploaded patch set 17 03/07/22, 14:39

  16. core-ci voted on patch set 16 V +1 03/07/22, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24661

  17. core-ci voted on patch set 15 V -1 03/07/22, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24660

  18. core-ci voted on patch set 17 V +1 03/07/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24662

  19. Benni Mack voted on patch set 17 V +1 CR +1 03/07/22, 15:04

  20. Oli Bartsch commented on patch set 17 V -1 03/07/22, 18:43

    on it
  21. Oli Bartsch uploaded patch set 18 03/07/22, 19:48

  22. Oli Bartsch voted on patch set 18 V +1 CR +1 03/07/22, 19:52

  23. core-ci voted on patch set 18 V +1 03/07/22, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24688

  24. Benni Mack voted on patch set 18 V +2 CR +2 03/07/22, 20:06

  25. Benni Mack merged patch set 19 03/07/22, 20:06