73801[TASK] Raise PHPStan to version 1.4.8
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1013
-
Nikita Hovratov uploaded patch set 1 03/03/22, 19:21
-
Oliver Klee commented on patch set 1 03/03/22, 19:29
Shouldn't we also target 11.5 (because we currently backport most of the fixes for PHPStan issues)? -
core-ci voted on patch set 1 V +1 03/03/22, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24528
-
Stefan Bürk commented on patch set 1 CR -1 03/03/22, 22:00
as Oliver stated, should be done for v11 also. We currently have some issues with phpstan/tf which we have to sort out first generally. Had the 1.4.7 raise locally prepared yesterday. Let us wait and sort out these thinks first please. -
Christian Kuhn uploaded patch set 2 03/04/22, 16:51
-
Christian Kuhn updated the commit message in patch set 3 03/04/22, 16:52
-
Christian Kuhn commented on patch set 2 03/04/22, 16:52
Reply
Done -
core-ci voted on patch set 2 V +1 03/04/22, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24570
-
core-ci voted on patch set 3 V +1 03/04/22, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24571
-
Oliver Klee voted on patch set 3 CR +1 03/04/22, 17:05
-
Stefan Bürk voted on patch set 3 V +1 CR +1 03/04/22, 17:29
-
Christian Kuhn voted on patch set 3 V +2 CR +2 03/04/22, 17:31
-
Christian Kuhn merged patch set 4 03/04/22, 17:32