Review main Merged

73807[BUGFIX] Undefined array key warning in static routes

Jochen Roth CR +2 V +2 Easy +1 −1 updated 03/04/22, 19:32

Commit message

When a creating a static route with a link
that does not contain a uid, php throws an undefined
array key warning.

This has been fixed by adding a fallback for pageuid.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1

Issues 1

Files 1

Review log 1011

  1. Jochen Roth uploaded patch set 1 03/04/22, 11:19

  2. Oliver Klee voted on patch set 1 CR +1 03/04/22, 11:34

  3. core-ci voted on patch set 1 V +1 03/04/22, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24550

  4. Oli Bartsch commented on patch set 1 03/04/22, 12:35

    InputLinkElement.php:360

    This might be a change in behaviour. Previously null had been passed to readPageAccess(), which then resulted in directly returning FLASE. Now, the first if condition "(string)$id !== ''" will be TURE since (string)0 => "0". When the user now is an admin, instead of FALSE, the ['_thePath' => '/'] array is returned. AFAICS this does not affect the code here but wanted to point this out.
  5. Jochen Roth updated the commit message in patch set 2 03/04/22, 13:34

  6. Jochen Roth uploaded patch set 3 03/04/22, 13:35

  7. Jochen Roth commented on patch set 3 03/04/22, 13:36

    InputLinkElement.php:360 Reply

    Done
  8. Oliver Klee voted on patch set 3 CR +1 03/04/22, 14:48

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 03/04/22, 19:31

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 03/04/22, 19:32

  11. Christian Kuhn merged patch set 4 03/04/22, 19:32