Review 11.5 Merged

73811[TASK] Raise PHPStan to version 1.4.8

Christian Kuhn CR +2 V +2 Hard +66 −341 updated 03/04/22, 17:32

Commit message

The new version finds some new possible bugs and
removes some incorrect ones. Combined with a TF
raise.

Used commands:
> composer req --dev phpstan/phpstan:^1.4.8
> composer req --dev typo3/testing-framework:^6.16.1
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/04/22, 17:08

  2. core-ci voted on patch set 1 V +1 03/04/22, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24572

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/04/22, 17:29

  4. Oliver Klee voted on patch set 1 CR +1 03/04/22, 17:31

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/04/22, 17:32

  6. Christian Kuhn merged patch set 2 03/04/22, 17:32