Review main Merged

73815[BUGFIX] Cast return value of method formMaxWidth to int

Nikita Hovratov CR +2 V +2 Easy +7 −12 updated 03/05/22, 21:00

Commit message

AbstractFormElement->formMaxWidth declares its
return type as of type int. But the ceil function
returns float. The return value is now cast to int
to prevent unexpected values.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1116

  1. Nikita Hovratov uploaded patch set 1 03/05/22, 11:37

  2. core-ci voted on patch set 1 V +1 03/05/22, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24606

  3. Oliver Klee voted on patch set 1 CR +1 03/05/22, 12:32

  4. Christian Kuhn updated the commit message in patch set 2 03/05/22, 20:23

  5. Christian Kuhn rebased onto patch set 3 03/05/22, 20:23

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 03/05/22, 20:29

  7. core-ci voted on patch set 3 V -1 03/05/22, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24626

  8. Christian Kuhn rebased onto patch set 4 03/05/22, 20:37

  9. core-ci voted on patch set 2 V +1 03/05/22, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24625

  10. core-ci voted on patch set 3 V +1 03/05/22, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24626

  11. core-ci voted on patch set 4 V +1 03/05/22, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24629

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 03/05/22, 20:54

  13. Stefan Bürk voted on patch set 4 V +1 CR +1 03/05/22, 20:55

  14. Oliver Klee voted on patch set 4 CR +1 03/05/22, 20:59

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 03/05/22, 21:00

  16. Christian Kuhn merged patch set 5 03/05/22, 21:00