73816[TASK] Remove TCA type "none" option "cols"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 4
Review log 910
-
Nikita Hovratov uploaded patch set 1 03/05/22, 13:30
-
core-ci voted on patch set 1 V +1 03/05/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24608
-
Christian Kuhn commented on patch set 1 03/05/22, 20:15
-
Nikita Hovratov commented on patch set 1 03/05/22, 20:26
NoneElement.php:28Replyinherited from AbstractFormElement. Can't change it. -
Christian Kuhn commented on patch set 1 03/05/22, 20:27
NoneElement.php:28ReplyAck. thx. -
Christian Kuhn voted on patch set 1 V +1 CR +1 03/05/22, 20:29
-
Stefan Bürk commented on patch set 1 V +1 CR +1 03/05/22, 20:52
Nikita, may you up to check if ext:styleguide needs eventually adoption afterwards ? To avoid that extension own ci jobs on github going red again -
Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/22, 20:53
-
Christian Kuhn merged patch set 2 03/05/22, 20:53
-
Nikita Hovratov commented on patch set 1 03/05/22, 20:53
Reply
yes, it needs adoption. Will take care.
NoneElement.php:28