Review main Merged

73816[TASK] Remove TCA type "none" option "cols"

Nikita Hovratov CR +2 V +2 Normal +170 −4 updated 03/05/22, 20:53

Commit message

The none type used to have an option "rows" to be
displayed as a textarea field. So it had "size" for
the normal input field and "cols" for the textarea
display. As the "rows" option got removed without
replacement in the TCA refactoring era, the none
type was left with two option keys with the same
functionality.

This patch removes the leftover "cols" option and
migrates the value to "size".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 910

  1. Nikita Hovratov uploaded patch set 1 03/05/22, 13:30

  2. core-ci voted on patch set 1 V +1 03/05/22, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24608

  3. Christian Kuhn commented on patch set 1 03/05/22, 20:15

    NoneElement.php:28

    type hint 'int'?
  4. Nikita Hovratov commented on patch set 1 03/05/22, 20:26

    NoneElement.php:28 Reply

    inherited from AbstractFormElement. Can't change it.
  5. Christian Kuhn commented on patch set 1 03/05/22, 20:27

    NoneElement.php:28 Reply

    Ack. thx.
  6. Christian Kuhn voted on patch set 1 V +1 CR +1 03/05/22, 20:29

  7. Stefan Bürk commented on patch set 1 V +1 CR +1 03/05/22, 20:52

    Nikita, may you up to check if ext:styleguide needs eventually adoption afterwards ? To avoid that extension own ci jobs on github going red again
  8. Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/22, 20:53

  9. Christian Kuhn merged patch set 2 03/05/22, 20:53

  10. Nikita Hovratov commented on patch set 1 03/05/22, 20:53

    Reply

    yes, it needs adoption. Will take care.