Review main Merged

73817[TASK] Replace ExpressionBuilder andX() / orX() usage

Stefan Bürk CR +2 V +2 Hard +206 −206 updated 03/05/22, 23:05

Commit message

doctrine/dbal moves their classes forward and deprecated
some stuff while providing replacement for it. This has
been early adopted for the core facade classes with #97081
in a forward-compatible way. Before deprecating the old
methods core usage have to be replaced.

Following ExpressionBuilder methods are replaced:

* 'andX()' with 'and()'
* 'orX()' with 'or()'

'and()' and 'or()' are made strict along the way.

This is a preparation to deprecate 'andX()' and 'orX()'
to align with ongoing deprecation and replacement of
doctrine/dbal changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 74

Show 54 more files

Review log 1014

  1. Stefan Bürk uploaded patch set 1 03/05/22, 13:56

  2. Stefan Bürk uploaded patch set 2 03/05/22, 13:57

  3. core-ci voted on patch set 1 V +1 03/05/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24609

  4. core-ci voted on patch set 2 V +1 03/05/22, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24610

  5. Stefan Bürk updated the commit message in patch set 3 03/05/22, 14:10

  6. Stefan Bürk wrote 03/05/22, 14:11

    Topic set to doctrine/dbal
  7. core-ci voted on patch set 3 V +1 03/05/22, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24611

  8. Nikita Hovratov commented on patch set 3 03/05/22, 21:36

    their
  9. Stefan Bürk updated the commit message in patch set 4 03/05/22, 21:37

  10. Stefan Bürk commented on patch set 4 03/05/22, 21:38

    Reply

    Done
  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 03/05/22, 21:39

  12. core-ci voted on patch set 4 V +1 03/05/22, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24632

  13. Christian Kuhn voted on patch set 4 V +2 CR +2 03/05/22, 23:05

  14. Christian Kuhn merged patch set 5 03/05/22, 23:05