Review main Merged

73820[TASK] Avoid unreachable code in RedirectService

Christian Kuhn CR +2 V +2 Easy +5 −24 updated 03/05/22, 21:19

Commit message

Since #94889 it is expected that single link
handler return a LinkInterface on build().
This is enforced, so some obsolete code can
be removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/05/22, 18:26

  2. core-ci voted on patch set 1 V +1 03/05/22, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24613

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/05/22, 20:49

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/05/22, 21:19

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/22, 21:19

  6. Christian Kuhn merged patch set 2 03/05/22, 21:19