Review main Merged

73821[TASK] Have correct return type on BackendUtility::getItemLabel()

Christian Kuhn CR +2 V +2 Easy +7 −24 updated 03/05/22, 21:13

Commit message

BackendUtility::getItemLabel() can happily return null.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Christian Kuhn uploaded patch set 1 03/05/22, 18:35

  2. core-ci voted on patch set 1 V +1 03/05/22, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24614

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/05/22, 20:46

  4. Oliver Klee voted on patch set 1 CR +1 03/05/22, 21:03

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/05/22, 21:12

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/22, 21:13

  7. Christian Kuhn merged patch set 2 03/05/22, 21:13