Review main Merged

73826[TASK] Avoid incomplete property type in form ConfigurationService

Christian Kuhn CR +2 V +2 Easy +1 −9 updated 03/05/22, 20:40

Commit message

Property $this->translationService can be null and
should be declared as such.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 03/05/22, 19:27

  2. core-ci voted on patch set 1 V +1 03/05/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24619

  3. Stefan Bürk voted on patch set 1 CR +1 03/05/22, 20:31

  4. Stefan Bürk voted on patch set 1 V +1 03/05/22, 20:34

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 03/05/22, 20:34

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/22, 20:40

  7. Christian Kuhn merged patch set 2 03/05/22, 20:40