Review 11.5 Merged

73830[BUGFIX] Cast return value of method formMaxWidth to int

Christian Kuhn CR +2 V +2 Easy +7 −12 updated 03/05/22, 21:12

Commit message

AbstractFormElement->formMaxWidth declares its
return type as of type int. But the ceil function
returns float. The return value is now cast to int
to prevent unexpected values.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/05/22, 21:00

  2. Oliver Klee voted on patch set 1 CR +1 03/05/22, 21:03

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 03/05/22, 21:06

  4. core-ci voted on patch set 1 V +1 03/05/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24631

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/22, 21:12

  6. Christian Kuhn merged patch set 2 03/05/22, 21:12