Review main Merged

73831[BUGFIX] Fix ResourceCompressor initialization in unit tests

Benjamin Franzke CR +2 V +2 Easy +6 −0 updated 03/06/22, 18:30

Commit message

With #97030 ResourceCompressor has been refactored to
avoid side effect initialization in the constructor (to be
injectable) and rather used an initialize() method that is
called from all public methods.

Withing unit tests protected methods are called
via an accessible mock directly, and thus caused
errors in random unit test runs when for example
typo3temp/assets/compressed/.htaccess had not been
created by a prior unit test in
getFilenamesFromMainDirInBackendContext().

initialize() is now called prior to using protected
methods in the ResourceCompressorTest unit test.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Benjamin Franzke uploaded patch set 1 03/06/22, 06:47

  2. core-ci voted on patch set 1 V -1 03/06/22, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24636

  3. Benjamin Franzke uploaded patch set 2 03/06/22, 06:59

  4. core-ci voted on patch set 2 V +1 03/06/22, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24637

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 03/06/22, 11:06

  6. Oliver Klee voted on patch set 2 CR +1 03/06/22, 11:09

  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 03/06/22, 15:09

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 03/06/22, 18:29

  9. Benjamin Franzke merged patch set 3 03/06/22, 18:30