Review main Merged

73837[BUGFIX] Do not cast pid to int in AddRecord

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 03/07/22, 17:42

Commit message

Since the pid, evaluated in AddRecord, might be
a marker such as '###PAGE_TSCONFIG_ID###',
the variable must not be cast to int.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 03/07/22, 15:05

  2. core-ci voted on patch set 1 V +1 03/07/22, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24664

  3. Oliver Klee updated the commit message in patch set 2 03/07/22, 15:18

  4. Oliver Klee voted on patch set 2 CR +1 03/07/22, 15:19

  5. core-ci voted on patch set 2 V +1 03/07/22, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24665

  6. Benni Mack voted on patch set 2 V +1 CR +1 03/07/22, 15:58

  7. Nikita Hovratov commented on patch set 2 CR -1 03/07/22, 17:23

  8. Nikita Hovratov commented on patch set 2 V +1 CR +1 03/07/22, 17:40

    Nevermind, all fine
  9. Oli Bartsch commented on patch set 2 V +2 CR +2 03/07/22, 17:42

  10. Oli Bartsch merged patch set 3 03/07/22, 17:42