Review main Merged

73842[BUGFIX] Initialize EditDocumentController->isSaveRecord

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 03/07/22, 21:30

Commit message

If "firstEl" is null, the property "isSaveRecord" is
not initialized and results in an uninitialized
property access error.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Nikita Hovratov uploaded patch set 1 03/07/22, 18:02

  2. core-ci voted on patch set 1 V +1 03/07/22, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24680

  3. Oliver Klee updated the commit message in patch set 2 03/07/22, 18:27

  4. Oliver Klee voted on patch set 2 CR +1 03/07/22, 18:28

  5. core-ci voted on patch set 2 V +1 03/07/22, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24682

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 03/07/22, 21:21

  7. Benni Mack voted on patch set 2 V +2 CR +2 03/07/22, 21:30

  8. Benni Mack merged patch set 3 03/07/22, 21:30