Review main Merged

73845[TASK] Simplify HMENU functionality

Benni Mack CR +2 V +2 Normal +76 −123 updated 03/11/22, 09:16

Commit message

This change moves some functionality that is only
relevant in TMENU into the class TextMenuContentObject
while simplifying various methods to understand
the flow of the menu generation (at least a tiny bit) better.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1520

  1. Benni Mack uploaded patch set 1 03/07/22, 22:06

  2. core-ci voted on patch set 1 V -1 03/07/22, 22:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24697

  3. Stefan Bürk commented on patch set 1 CR -1 03/07/22, 22:29

    on it
  4. Stefan Bürk uploaded patch set 2 03/07/22, 22:37

  5. core-ci voted on patch set 2 V +1 03/07/22, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24698

  6. Stefan Bürk voted on patch set 2 CR +1 03/07/22, 22:52

  7. Stefan Bürk voted on patch set 2 V +1 03/07/22, 22:56

  8. Oli Bartsch voted on patch set 2 V -1 03/10/22, 11:36

  9. Benni Mack uploaded patch set 3 03/10/22, 16:51

  10. Benni Mack updated the commit message in patch set 4 03/10/22, 16:52

  11. core-ci voted on patch set 4 V -1 03/10/22, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24814

  12. core-ci voted on patch set 3 V -1 03/10/22, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24813

  13. Benni Mack commented on patch set 5 03/10/22, 20:29

    Published edit on patch set 4.
  14. core-ci voted on patch set 5 V +1 03/10/22, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24820

  15. Stefan Bürk voted on patch set 5 V +1 CR +1 03/11/22, 08:19

  16. Oli Bartsch commented on patch set 5 03/11/22, 09:06

    ^

    TextMenuContentObject.php:29

    Do we need those class properties? Wouldn't it be sufficient to just use local variables in writeMenu()?
  17. Benni Mack commented on patch set 5 03/11/22, 09:07

    TextMenuContentObject.php:29 Reply

    will go over the "huge method" again, for further refinements. In a separate patch
  18. Oli Bartsch commented on patch set 5 V +1 CR +1 03/11/22, 09:16

    TextMenuContentObject.php:29 Reply

    Ok
  19. Benni Mack voted on patch set 5 V +2 CR +2 03/11/22, 09:16

  20. Benni Mack merged patch set 6 03/11/22, 09:16