73845[TASK] Simplify HMENU functionality
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+20 −37
- typo3/sysext/frontend/Classes/ContentObject/Menu/MenuContentObjectFactory.php+7 −10
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php3+40 −74
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/MenuContentObjectFactoryTest.php+9 −2
Review log 1520
-
Benni Mack uploaded patch set 1 03/07/22, 22:06
-
core-ci voted on patch set 1 V -1 03/07/22, 22:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24697
-
Stefan Bürk commented on patch set 1 CR -1 03/07/22, 22:29
on it -
Stefan Bürk uploaded patch set 2 03/07/22, 22:37
-
core-ci voted on patch set 2 V +1 03/07/22, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24698
-
Stefan Bürk voted on patch set 2 CR +1 03/07/22, 22:52
-
Stefan Bürk voted on patch set 2 V +1 03/07/22, 22:56
-
Oli Bartsch voted on patch set 2 V -1 03/10/22, 11:36
-
Benni Mack uploaded patch set 3 03/10/22, 16:51
-
Benni Mack updated the commit message in patch set 4 03/10/22, 16:52
-
core-ci voted on patch set 4 V -1 03/10/22, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24814
-
core-ci voted on patch set 3 V -1 03/10/22, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24813
-
Benni Mack commented on patch set 5 03/10/22, 20:29
Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 03/10/22, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24820
-
Stefan Bürk voted on patch set 5 V +1 CR +1 03/11/22, 08:19
-
Oli Bartsch commented on patch set 5 03/11/22, 09:06
^TextMenuContentObject.php:29Do we need those class properties? Wouldn't it be sufficient to just use local variables in writeMenu()? -
Benni Mack commented on patch set 5 03/11/22, 09:07
TextMenuContentObject.php:29Replywill go over the "huge method" again, for further refinements. In a separate patch -
Oli Bartsch commented on patch set 5 V +1 CR +1 03/11/22, 09:16
TextMenuContentObject.php:29ReplyOk -
Benni Mack voted on patch set 5 V +2 CR +2 03/11/22, 09:16
-
Benni Mack merged patch set 6 03/11/22, 09:16