73857[DOCS] Registration for custom linkvalidator linktypes
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/AbstractLinktype.rst.txtnew+53 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/LinkAnalyzerResult.rst.txtnew+53 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/LinktypeInterface.rst.txtnew+60 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ActivateCustomLinktypeTsConfig.rst.txt2new+8 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ExampleLinkType.rst.txtnew+30 −0
- typo3/sysext/linkvalidator/Documentation/Configuration/Index.rst+2 −2
- typo3/sysext/linkvalidator/Documentation/Development/Api/AbstractLinktype.rst2new+9 −0
- typo3/sysext/linkvalidator/Documentation/Development/Api/Index.rst4new+19 −0
- typo3/sysext/linkvalidator/Documentation/Development/Api/LinkAnalyzerResult.rstnew+15 −0
- typo3/sysext/linkvalidator/Documentation/Development/Api/LinktypeInterface.rstnew+9 −0
- typo3/sysext/linkvalidator/Documentation/Development/Index.rstnew+42 −0
- typo3/sysext/linkvalidator/Documentation/Development/LinkTypeImplementation.rst9new+80 −0
- typo3/sysext/linkvalidator/Documentation/Index.rst+1 −0
Review log 3144
Show 1419 earlier messages
-
Lina Wolf uploaded patch set 1 03/08/22, 13:29
-
core-ci voted on patch set 1 V +1 03/08/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24713
-
Nikita Hovratov uploaded patch set 2 03/09/22, 12:05
-
core-ci voted on patch set 2 V -1 03/09/22, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24744
-
Lina Wolf commented on patch set 2 03/09/22, 12:24
-
Nikita Hovratov uploaded patch set 3 03/09/22, 13:20
-
Nikita Hovratov commented on patch set 2 03/09/22, 13:20
LinkTypeImplementation.rst:13ReplyAdded it back, but the link is still not working. -
core-ci voted on patch set 3 V +1 03/09/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24749
-
Lina Wolf commented on patch set 3 03/10/22, 07:30
LinkTypeImplementation.rst:13ReplyLet me have a look next weekend -
Lina Wolf marked it work in progress 03/10/22, 07:30
-
Lina Wolf uploaded patch set 4 03/12/22, 12:41
-
Lina Wolf commented on patch set 4 03/12/22, 12:43
This change is ready for review.LinkTypeImplementation.rst:13ReplySo the backslashes have to be escaped with a double backslash. Fixed it now it renders fine. -
Lina Wolf commented on patch set 4 03/12/22, 12:43
I fixed the rendering warnings and errors, looks fine on my machine now. -
core-ci voted on patch set 4 V +1 03/12/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24849
-
Jörg Bösche voted on patch set 4 CR +1 04/27/22, 11:44
-
Lina Wolf uploaded patch set 5 06/11/22, 12:05
-
Lina Wolf uploaded patch set 6 06/11/22, 12:11
-
core-ci voted on patch set 5 V -1 06/11/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27973
-
Chris Müller commented on patch set 6 CR -1 06/11/22, 17:16
ActivateCustomLinktypeTsConfig.rst.txt:3TSconfig -> TsConfigLinkTypeImplementation.rst:69LTS 11 -> TYPO3 11 LTS
-
Alexander Nitsche commented on patch set 6 CR -1 06/21/22, 09:17
AbstractLinktype.rst:1Include the existing /Includes.rst.txt instead of adding and including an outdated /Includes.txt (additional usage in other files).Index.rst:14:glob: is not used in this TOC => can be omitted.Includes.txt:1Use the existing /Includes.rst.txt and remove this outdated /Includes.txt. -
Lina Wolf rebased onto patch set 7 06/22/22, 09:58
-
core-ci voted on patch set 7 V +1 06/22/22, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28329
-
Lina Wolf uploaded patch set 8 06/22/22, 10:07
-
Lina Wolf uploaded patch set 9 06/22/22, 10:09
-
Lina Wolf commented on patch set 9 06/22/22, 10:09
ActivateCustomLinktypeTsConfig.rst.txt:3ReplyDoneAbstractLinktype.rst:1ReplyRebased and applied the new schemeIndex.rst:14ReplyDoneLinkTypeImplementation.rst:69ReplyDoneIncludes.txt:1ReplyDone -
core-ci voted on patch set 8 V +1 06/22/22, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28330
-
core-ci voted on patch set 9 V -1 06/22/22, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28331
-
Alexander Nitsche voted on patch set 9 CR +1 06/22/22, 10:26
-
core-ci commented on patch set 9 06/22/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28331
-
core-ci voted on patch set 9 V +1 06/22/22, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28331
-
Chris Müller commented on patch set 9 06/22/22, 11:22
Index.rst:10Shouldn't it be "... have a look into the code"?LinkTypeImplementation.rst:50Reads a little bit odd, maybe a comma before "this file must either contain" -
Alexander Nitsche commented on patch set 9 06/22/22, 11:43
LinkTypeImplementation.rst:50Replydeepl.com suggests "The extension that provides the link type must have a :file:`Configuration/Services.yaml` file that contains either:" -
Chris Müller uploaded patch set 10 06/22/22, 15:44
-
core-ci voted on patch set 10 V +1 06/22/22, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28338
-
Chris Müller commented on patch set 10 V +1 CR +1 06/22/22, 15:56
Index.rst:10ReplyDoneLinkTypeImplementation.rst:50ReplyDone -
Alexander Nitsche voted on patch set 10 CR +1 06/22/22, 17:49
-
Jörg Bösche voted on patch set 10 CR +1 06/23/22, 13:41
-
Lina Wolf rebased onto patch set 11 06/29/22, 10:45
-
core-ci voted on patch set 11 V +1 06/29/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28479
-
Nikita Hovratov uploaded patch set 12 07/05/22, 15:57
-
Nikita Hovratov voted on patch set 12 V +1 CR +1 07/05/22, 15:58
-
core-ci voted on patch set 12 V +1 07/05/22, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28677
-
Stefan Bürk voted on patch set 12 V +2 CR +2 07/07/22, 19:41
-
Stefan Bürk merged patch set 13 07/07/22, 19:41
LinkTypeImplementation.rst:13