Review main Merged

73857[DOCS] Registration for custom linkvalidator linktypes

Lina Wolf CR +2 V +2 Hard +381 −2 updated 07/07/22, 19:41

Commit message

Introduce development and API section, so they can be referenced.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 3144

Show 1419 earlier messages
  1. Lina Wolf uploaded patch set 1 03/08/22, 13:29

  2. core-ci voted on patch set 1 V +1 03/08/22, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24713

  3. Nikita Hovratov uploaded patch set 2 03/09/22, 12:05

  4. core-ci voted on patch set 2 V -1 03/09/22, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24744

  5. Lina Wolf commented on patch set 2 03/09/22, 12:24

    LinkTypeImplementation.rst:13

    We need to keep the links of the syntax :php:interface: and :php:class: as these link directly to the classes php domain definition while :php: is only formated as code.
  6. Nikita Hovratov uploaded patch set 3 03/09/22, 13:20

  7. Nikita Hovratov commented on patch set 2 03/09/22, 13:20

    LinkTypeImplementation.rst:13 Reply

    Added it back, but the link is still not working.
  8. core-ci voted on patch set 3 V +1 03/09/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24749

  9. Lina Wolf commented on patch set 3 03/10/22, 07:30

    LinkTypeImplementation.rst:13 Reply

    Let me have a look next weekend
  10. Lina Wolf marked it work in progress 03/10/22, 07:30

  11. Lina Wolf uploaded patch set 4 03/12/22, 12:41

  12. Lina Wolf commented on patch set 4 03/12/22, 12:43

    This change is ready for review.

    LinkTypeImplementation.rst:13 Reply

    So the backslashes have to be escaped with a double backslash. Fixed it now it renders fine.
  13. Lina Wolf commented on patch set 4 03/12/22, 12:43

    I fixed the rendering warnings and errors, looks fine on my machine now.
  14. core-ci voted on patch set 4 V +1 03/12/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24849

  15. Jörg Bösche voted on patch set 4 CR +1 04/27/22, 11:44

  16. Lina Wolf uploaded patch set 5 06/11/22, 12:05

  17. Lina Wolf uploaded patch set 6 06/11/22, 12:11

  18. core-ci voted on patch set 5 V -1 06/11/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27973

  19. Chris Müller commented on patch set 6 CR -1 06/11/22, 17:16

    ActivateCustomLinktypeTsConfig.rst.txt:3

    TSconfig -> TsConfig

    LinkTypeImplementation.rst:69

    LTS 11 -> TYPO3 11 LTS
  1. Alexander Nitsche commented on patch set 6 CR -1 06/21/22, 09:17

    AbstractLinktype.rst:1

    Include the existing /Includes.rst.txt instead of adding and including an outdated /Includes.txt (additional usage in other files).

    Index.rst:14

    :glob: is not used in this TOC => can be omitted.

    Includes.txt:1

    Use the existing /Includes.rst.txt and remove this outdated /Includes.txt.
  2. Lina Wolf rebased onto patch set 7 06/22/22, 09:58

  3. core-ci voted on patch set 7 V +1 06/22/22, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28329

  4. Lina Wolf uploaded patch set 8 06/22/22, 10:07

  5. Lina Wolf uploaded patch set 9 06/22/22, 10:09

  6. Lina Wolf commented on patch set 9 06/22/22, 10:09

    ActivateCustomLinktypeTsConfig.rst.txt:3 Reply

    Done

    AbstractLinktype.rst:1 Reply

    Rebased and applied the new scheme

    Index.rst:14 Reply

    Done

    LinkTypeImplementation.rst:69 Reply

    Done

    Includes.txt:1 Reply

    Done
  7. core-ci voted on patch set 8 V +1 06/22/22, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28330

  8. core-ci voted on patch set 9 V -1 06/22/22, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28331

  9. Alexander Nitsche voted on patch set 9 CR +1 06/22/22, 10:26

  10. core-ci commented on patch set 9 06/22/22, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28331

  11. core-ci voted on patch set 9 V +1 06/22/22, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28331

  12. Chris Müller commented on patch set 9 06/22/22, 11:22

    Index.rst:10

    Shouldn't it be "... have a look into the code"?

    LinkTypeImplementation.rst:50

    Reads a little bit odd, maybe a comma before "this file must either contain"
  13. Alexander Nitsche commented on patch set 9 06/22/22, 11:43

    LinkTypeImplementation.rst:50 Reply

    deepl.com suggests "The extension that provides the link type must have a :file:`Configuration/Services.yaml` file that contains either:"
  14. Chris Müller uploaded patch set 10 06/22/22, 15:44

  15. core-ci voted on patch set 10 V +1 06/22/22, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28338

  16. Chris Müller commented on patch set 10 V +1 CR +1 06/22/22, 15:56

    Index.rst:10 Reply

    Done

    LinkTypeImplementation.rst:50 Reply

    Done
  17. Alexander Nitsche voted on patch set 10 CR +1 06/22/22, 17:49

  18. Jörg Bösche voted on patch set 10 CR +1 06/23/22, 13:41

  19. Lina Wolf rebased onto patch set 11 06/29/22, 10:45

  20. core-ci voted on patch set 11 V +1 06/29/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28479

  21. Nikita Hovratov uploaded patch set 12 07/05/22, 15:57

  22. Nikita Hovratov voted on patch set 12 V +1 CR +1 07/05/22, 15:58

  23. core-ci voted on patch set 12 V +1 07/05/22, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28677

  24. Stefan Bürk voted on patch set 12 V +2 CR +2 07/07/22, 19:41

  25. Stefan Bürk merged patch set 13 07/07/22, 19:41