Review 10.4 Merged

73858[BUGFIX] Avoid errors when using sys_history migration

Benni Mack CR +2 V +2 Easy +1 −1 updated 03/15/22, 16:18

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Benni Mack uploaded patch set 1 03/08/22, 16:03

  2. core-ci voted on patch set 1 V +1 03/08/22, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24717

  3. Oliver Klee voted on patch set 1 CR +1 03/08/22, 17:40

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 03/14/22, 19:12

  5. Simon Schaufelberger voted on patch set 1 V +1 CR +1 03/15/22, 15:31

  6. Simon Schaufelberger commented on patch set 1 03/15/22, 15:32

    shouldn't the Releases line be like: main, 11.5, 10.4?
  7. Benni Mack commented on patch set 1 03/15/22, 15:47

    The upgrade wizard is for v9 upgrades, so the piece of code does not exist in v11+ anymore, as upgrade wizards are only kept for 2 major versions (in this case v9 and v10).
  8. Simon Schaufelberger commented on patch set 1 03/15/22, 16:12

    right, i was just thinking about the new json format in sys_log but that's a different story ;)
  9. Oli Bartsch voted on patch set 1 V +1 CR +1 03/15/22, 16:14

  10. Oli Bartsch voted on patch set 1 V +2 CR +2 03/15/22, 16:18

  11. Oli Bartsch merged patch set 2 03/15/22, 16:18