Review main Merged

73859[BUGFIX] Unify handling of reading from sys_log.log_data

Benni Mack CR +2 V +2 Normal +137 −43 updated 03/09/22, 18:20

Commit message

This change allows using PSR-3 provided placeholders
such as "{myVariable}" in various places related to logging
rendering, and fixes places in DataHandler where
placeholders weren't used in the past and hard-coded
strings were used instead of labels.

Various logging calls to sys_log can now be read in
a unified way, as the Logging API already used the
placeholders in some places.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1522

  1. Benni Mack uploaded patch set 1 03/08/22, 16:31

  2. Benni Mack updated the commit message in patch set 2 03/08/22, 16:32

  3. core-ci voted on patch set 1 V -1 03/08/22, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24720

  4. core-ci voted on patch set 2 V +1 03/08/22, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24721

  5. Benni Mack uploaded patch set 3 03/09/22, 06:32

  6. core-ci voted on patch set 3 V -1 03/09/22, 06:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24726

  7. Benni Mack uploaded patch set 4 03/09/22, 06:55

  8. core-ci voted on patch set 4 V +1 03/09/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24728

  9. Benni Mack commented on patch set 5 03/09/22, 07:53

    Published edit on patch set 4.
  10. Nikita Hovratov uploaded patch set 6 03/09/22, 07:56

  11. Nikita Hovratov uploaded patch set 7 03/09/22, 07:58

  12. core-ci voted on patch set 7 V +1 03/09/22, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24732

  13. Benni Mack uploaded patch set 8 03/09/22, 08:30

  14. core-ci voted on patch set 8 V -1 03/09/22, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24733

  15. Benni Mack uploaded patch set 9 03/09/22, 08:48

  16. core-ci voted on patch set 9 V +1 03/09/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24734

  17. Jochen Roth voted on patch set 9 V +1 CR +1 03/09/22, 09:11

  18. Oli Bartsch voted on patch set 9 V +1 CR +1 03/09/22, 09:31

  19. Benni Mack voted on patch set 9 V +2 CR +2 03/09/22, 11:31

  20. Benni Mack merged patch set 10 03/09/22, 11:31

  21. Stefan Bürk commented on patch set 10 03/09/22, 15:52

    post-merge -1

    LogDataTrait.php:33

    (string) cast should be wise, as argument type is mixed

    LogDataTrait.php:35

    (string) cast should be wise, as argument type is mixed
  22. Stefan Bürk commented on patch set 10 03/09/22, 17:55

    LogDataTrait.php:33 Reply

    will be added withanother patch.

    LogDataTrait.php:35 Reply

    will be added withanother patch.