73859[BUGFIX] Unify handling of reading from sys_log.log_data
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Security/FailedLoginAttemptNotification.php+4 −2
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+5 −5
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+3 −6
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+25 −25
- typo3/sysext/core/Classes/Log/LogDataTrait.php4new+71 −0
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+3 −2
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+17 −0
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+5 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+4 −1
Review log 1522
-
Benni Mack uploaded patch set 1 03/08/22, 16:31
-
Benni Mack updated the commit message in patch set 2 03/08/22, 16:32
-
core-ci voted on patch set 1 V -1 03/08/22, 16:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24720
-
core-ci voted on patch set 2 V +1 03/08/22, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24721
-
Benni Mack uploaded patch set 3 03/09/22, 06:32
-
core-ci voted on patch set 3 V -1 03/09/22, 06:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24726
-
Benni Mack uploaded patch set 4 03/09/22, 06:55
-
core-ci voted on patch set 4 V +1 03/09/22, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24728
-
Benni Mack commented on patch set 5 03/09/22, 07:53
Published edit on patch set 4. -
Nikita Hovratov uploaded patch set 6 03/09/22, 07:56
-
Nikita Hovratov uploaded patch set 7 03/09/22, 07:58
-
core-ci voted on patch set 7 V +1 03/09/22, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24732
-
Benni Mack uploaded patch set 8 03/09/22, 08:30
-
core-ci voted on patch set 8 V -1 03/09/22, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24733
-
Benni Mack uploaded patch set 9 03/09/22, 08:48
-
core-ci voted on patch set 9 V +1 03/09/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24734
-
Jochen Roth voted on patch set 9 V +1 CR +1 03/09/22, 09:11
-
Oli Bartsch voted on patch set 9 V +1 CR +1 03/09/22, 09:31
-
Benni Mack voted on patch set 9 V +2 CR +2 03/09/22, 11:31
-
Benni Mack merged patch set 10 03/09/22, 11:31
-
Stefan Bürk commented on patch set 10 03/09/22, 15:52
post-merge -1LogDataTrait.php:33(string) cast should be wise, as argument type is mixedLogDataTrait.php:35(string) cast should be wise, as argument type is mixed -
Stefan Bürk commented on patch set 10 03/09/22, 17:55
LogDataTrait.php:33Replywill be added withanother patch.LogDataTrait.php:35Replywill be added withanother patch.