Review main Merged

73860[BUGFIX] Check array key uid before accessing it

Georg Ringer CR +2 V +2 Easy +1 −1 updated 03/09/22, 09:08

Commit message

The uid might not be set if not part of the select fields. A check is
needed to avoid an undefined array key error.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 03/09/22, 07:28

  2. Georg Ringer commented on patch set 1 03/09/22, 07:28

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/09/22, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24729

  4. Benni Mack commented on patch set 1 03/09/22, 08:13

    ContentContentObject.php:89

    should we just skip the record if $row['uid'] is not defined?
  5. Benni Mack voted on patch set 1 V +1 CR +1 03/09/22, 08:21

  6. Benni Mack commented on patch set 1 03/09/22, 08:22

    ContentContentObject.php:89 Reply

    Just read the ticket, all good.
  7. Oli Bartsch voted on patch set 1 V +2 CR +2 03/09/22, 09:08

  8. Oli Bartsch merged patch set 2 03/09/22, 09:08