Review main Merged

73861[BUGFIX] Use sys_history for workspaces stage changes + comments

Benni Mack CR +2 V +2 Normal +129 −37 updated 03/14/22, 12:42

Commit message

Historically, a stage change
(publishing or "editing => ready to publish") has been
tracked - along with the comment in sys_log with the
action=6 (update) and details_nr=30, where then the logs
are read again for the workspaces module.

Reading from sys_log is a problem as this data is
very volatile (there is even a scheduler task to delete
old sys_log entries older than e.g. 90 days, so we loose
comments).

This change now stores the information inside the
sys_history table about a stage change, so the history
of such an action is preserved, along with the comment.

The workspaces module now reads from sys_history (via
RecordHistory class) and from sys_log if there are
still old comments.

The reading from sys_log can then be removed at a later
change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1322

  1. Benni Mack uploaded patch set 1 03/09/22, 13:45

  2. Benni Mack commented on patch set 2 03/09/22, 13:53

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 03/09/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24750

  4. core-ci voted on patch set 2 V -1 03/09/22, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24751

  5. Benni Mack uploaded patch set 3 03/09/22, 20:16

  6. core-ci voted on patch set 3 V -1 03/09/22, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24767

  7. Benni Mack uploaded patch set 4 03/09/22, 20:58

  8. Benni Mack uploaded patch set 5 03/09/22, 20:59

  9. core-ci voted on patch set 4 V +1 03/09/22, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24769

  10. core-ci voted on patch set 5 V +1 03/09/22, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24770

  11. Benni Mack updated the commit message in patch set 6 03/09/22, 21:17

  12. Benni Mack updated the commit message in patch set 7 03/09/22, 21:19

  13. core-ci voted on patch set 6 V +1 03/09/22, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24773

  14. core-ci voted on patch set 7 V +1 03/09/22, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24774

  15. Benni Mack commented on patch set 8 03/09/22, 21:41

    Published edit on patch set 7.
  16. core-ci voted on patch set 8 V +1 03/09/22, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24775

  17. Susi Moog uploaded patch set 9 03/14/22, 11:45

  18. Susi Moog voted on patch set 9 V +1 CR +1 03/14/22, 11:46

  19. core-ci voted on patch set 9 V +1 03/14/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24875

  20. Oli Bartsch voted on patch set 9 V +1 CR +1 03/14/22, 12:13

  21. Benni Mack voted on patch set 9 V +2 CR +2 03/14/22, 12:42

  22. Benni Mack merged patch set 10 03/14/22, 12:42