Review main Abandoned

73862[BUGFIX] Make file paths absolute in GIFBUILDER

Simon Schaufelberger CR 0 V 0 Hard +246 −75 updated 06/04/22, 20:54

Commit message

In CLI context the full path to the temporary generated file by the
GIFBUILDER can't be resolved. Because of this inconsistency, absolute
file paths are used from now on.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 1422

  1. Simon Schaufelberger uploaded patch set 1 03/09/22, 14:48

  2. Simon Schaufelberger commented on patch set 1 03/09/22, 14:53

    This is a second approach of https://review.typo3.org/c/Packages/TYPO3.CMS/+/71335 which was reverted because it didn't work properly.
  3. core-ci voted on patch set 1 V -1 03/09/22, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24753

  4. Simon Schaufelberger uploaded patch set 2 03/10/22, 02:48

  5. core-ci voted on patch set 2 V -1 03/10/22, 03:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24781

  6. Simon Schaufelberger uploaded patch set 3 03/10/22, 15:19

  7. core-ci voted on patch set 3 V -1 03/10/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24799

  8. Simon Schaufelberger uploaded patch set 4 03/14/22, 22:43

  9. core-ci voted on patch set 4 V +1 03/14/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24895

  10. Simon Schaufelberger commented on patch set 4 03/14/22, 23:06

    GraphicalFunctions.php:2220

    This line has a lot of consequenses in many other places but if I return always the absolute path, I need to change the ImageContentObject because if I use the Gifbuilder, it will return an absolute path then and in that case I need to make it a public web path again, so either one way or the other but at the moment the third index sometimes returns an absolute path and sometimes a relative path.
  11. Simon Schaufelberger commented on patch set 4 03/14/22, 23:49

    GraphicalFunctions.php:2220 Reply Unresolved

    Please also have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73932 which might be the better solution as I work with absolute paths here always.
  12. Simon Schaufelberger rebased onto patch set 5 03/21/22, 16:11

  13. core-ci voted on patch set 5 V +1 03/21/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25035

  14. Simon Schaufelberger uploaded patch set 6 03/22/22, 16:08

  15. core-ci voted on patch set 6 V -1 03/22/22, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25052

  16. Simon Schaufelberger rebased onto patch set 7 03/28/22, 19:08

  17. core-ci voted on patch set 7 V -1 03/28/22, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25227

  18. Simon Schaufelberger uploaded patch set 8 03/28/22, 19:28

  19. Simon Schaufelberger commented on patch set 8 03/28/22, 19:28

  20. core-ci voted on patch set 8 V +1 03/28/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25229

  21. Simon Schaufelberger marked it work in progress 04/26/22, 19:43

  22. Nikita Hovratov abandoned the change 06/04/22, 20:54