73862[BUGFIX] Make file paths absolute in GIFBUILDER
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php2+26 −19
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+5 −4
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+5 −4
- typo3/sysext/core/Classes/Resource/Processing/LocalPreviewHelper.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+4 −3
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+19 −17
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+159 −1
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+26 −26
Review log 1422
-
Simon Schaufelberger uploaded patch set 1 03/09/22, 14:48
-
Simon Schaufelberger commented on patch set 1 03/09/22, 14:53
This is a second approach of https://review.typo3.org/c/Packages/TYPO3.CMS/+/71335 which was reverted because it didn't work properly. -
core-ci voted on patch set 1 V -1 03/09/22, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24753
-
Simon Schaufelberger uploaded patch set 2 03/10/22, 02:48
-
core-ci voted on patch set 2 V -1 03/10/22, 03:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24781
-
Simon Schaufelberger uploaded patch set 3 03/10/22, 15:19
-
core-ci voted on patch set 3 V -1 03/10/22, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24799
-
Simon Schaufelberger uploaded patch set 4 03/14/22, 22:43
-
core-ci voted on patch set 4 V +1 03/14/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24895
-
Simon Schaufelberger commented on patch set 4 03/14/22, 23:06
GraphicalFunctions.php:2220This line has a lot of consequenses in many other places but if I return always the absolute path, I need to change the ImageContentObject because if I use the Gifbuilder, it will return an absolute path then and in that case I need to make it a public web path again, so either one way or the other but at the moment the third index sometimes returns an absolute path and sometimes a relative path. -
Simon Schaufelberger commented on patch set 4 03/14/22, 23:49
GraphicalFunctions.php:2220Reply UnresolvedPlease also have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73932 which might be the better solution as I work with absolute paths here always. -
Simon Schaufelberger rebased onto patch set 5 03/21/22, 16:11
-
core-ci voted on patch set 5 V +1 03/21/22, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25035
-
Simon Schaufelberger uploaded patch set 6 03/22/22, 16:08
-
core-ci voted on patch set 6 V -1 03/22/22, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25052
-
Simon Schaufelberger rebased onto patch set 7 03/28/22, 19:08
-
core-ci voted on patch set 7 V -1 03/28/22, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25227
-
Simon Schaufelberger uploaded patch set 8 03/28/22, 19:28
-
Simon Schaufelberger commented on patch set 8 03/28/22, 19:28
Info: There is a better solution here: https://review.typo3.org/q/If3a8613ed8e8d11a1b8a474fa564f947ef8a5c0c -
core-ci voted on patch set 8 V +1 03/28/22, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25229
-
Simon Schaufelberger marked it work in progress 04/26/22, 19:43
-
Nikita Hovratov abandoned the change 06/04/22, 20:54