Review main Merged

73865[TASK] Streamline EXT:recycler PHP code

Benni Mack CR +2 V +2 Hard +134 −201 updated 03/10/22, 11:11

Commit message

This is a first patch to clean up the code in
EXT:recycler:

* Use DI in RecyclerAjaxController
* Remove "Tables" Model (only used internally and only once)
* Move helper functions from RecyclerUtility into protected methods

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 710

  1. Benni Mack uploaded patch set 1 03/09/22, 20:48

  2. core-ci voted on patch set 1 V -1 03/09/22, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24768

  3. Benni Mack uploaded patch set 2 03/09/22, 21:07

  4. core-ci voted on patch set 2 V -1 03/09/22, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24771

  5. Benni Mack uploaded patch set 3 03/09/22, 22:20

  6. core-ci voted on patch set 3 V +1 03/09/22, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24778

  7. Benjamin Franzke voted on patch set 3 V +1 CR +1 03/10/22, 09:10

  8. Benjamin Franzke wrote 03/10/22, 09:11

    Topic set to di
  9. Oli Bartsch voted on patch set 3 V +2 CR +2 03/10/22, 11:11

  10. Oli Bartsch merged patch set 4 03/10/22, 11:11