73866[FEATURE] Introduce TCA type "link"
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Susi Moog +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 45
- Build/phpstan/phpstan-baseline.neon+0 −5
- Build/Sources/TypeScript/backend/form-engine/element/input-link-element.tsdeleted+0 −78
- Build/Sources/TypeScript/backend/form-engine/element/link-element.tsnew+95 −0
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+3 −0
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php2renamed+140 −91
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+12 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsProcessPlaceholders.php+1 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+4 −16
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php+1 −1
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+2 −0
- typo3/sysext/backend/Configuration/SiteConfiguration/site_errorhandling.php+2 −9
- typo3/sysext/backend/Configuration/SiteConfiguration/site_route.php+2 −9
- typo3/sysext/backend/Migrations/Code/ClassAliasMap.phpnew+20 −0
- typo3/sysext/backend/Migrations/Code/LegacyClassesForIde.phpnew+26 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/input-link-element.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/link-element.jsnew+13 −0
- typo3/sysext/backend/composer.json+5 −0
Show 25 more files
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+3 −3
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+67 −4
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+101 −0
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+1 −0
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+3 −10
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97013-NewTCATypeEmail.rst+5 −3
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97159-NewTCATypeLink.rst2new+173 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Important-97159-MailLinkHandlerKeyInTSconfigRenamed.rstnew+21 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+239 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+3 −11
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php+5 −12
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+5 −0
- typo3/sysext/lowlevel/Classes/Database/QueryGenerator.php+2 −0
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+12 −10
- typo3/sysext/recordlist/Classes/LinkHandler/FileLinkHandler.php+2 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −0
- typo3/sysext/recordlist/Configuration/page.tsconfig+1 −1
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+4 −11
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+12 −8
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.php+5 −13
- composer.json+3 −0
- composer.lock+1 −1
Review log 2438
Show 613 earlier messages
-
Oli Bartsch uploaded patch set 1 03/09/22, 22:01
-
core-ci voted on patch set 1 V -1 03/09/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24776
-
Oli Bartsch uploaded patch set 2 03/10/22, 15:27
-
core-ci voted on patch set 2 V -1 03/10/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24800
-
Oli Bartsch uploaded patch set 3 03/10/22, 15:51
-
core-ci voted on patch set 3 V -1 03/10/22, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24804
-
Oli Bartsch uploaded patch set 4 03/10/22, 23:58
-
core-ci voted on patch set 4 V -1 03/11/22, 00:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24822
-
Oli Bartsch uploaded patch set 5 03/11/22, 09:59
-
core-ci voted on patch set 5 V -1 03/11/22, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24831
-
core-ci voted on patch set 5 V +1 03/11/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24831
-
Oli Bartsch uploaded patch set 6 03/11/22, 14:46
-
core-ci voted on patch set 6 V +1 03/11/22, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24834
-
Oli Bartsch uploaded patch set 7 03/11/22, 16:27
-
core-ci voted on patch set 7 V +1 03/11/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24836
-
Oli Bartsch uploaded patch set 8 03/11/22, 18:09
-
Oli Bartsch updated the commit message in patch set 9 03/11/22, 18:15
-
core-ci voted on patch set 8 V -1 03/11/22, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24837
-
core-ci voted on patch set 9 V +1 03/11/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24838
-
Benni Mack voted on patch set 9 V +1 CR +1 03/11/22, 18:44
-
Oli Bartsch uploaded patch set 10 03/11/22, 20:23
-
core-ci voted on patch set 10 V +1 03/11/22, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24841
-
Benni Mack voted on patch set 10 V +1 CR +1 03/12/22, 20:40
-
Susi Moog commented on patch set 10 V -1 03/14/22, 12:19
did some basic testing - in general +1, however in flexform context some appearance related options don't seem to work or I'm doing something wrong - I tried to adapt the rst example, disabling the browser did have no effect, browserTitle is not displayed (or I don't know where that is displayed) and no field for "rel" is displayed, however, allowedFileExtensions works: <link_1> <TCEforms> <label>link1</label> <config> <type>link</type> <required>true</required> <size>55</size> <allowedTypes type="array"> <numIndex index="0">page</numIndex> <numIndex index="1">url</numIndex> <numIndex index="2">record</numIndex> <numIndex index="3">file</numIndex> </allowedTypes> <appearance> <enableBrowser>false</enableBrowser> <browserTitle>Hannelore</browserTitle> <allowedFileExtensions type="array"> <numIndex index="0">jpg</numIndex> <numIndex index="1">png</numIndex> </allowedFileExtensions> <allowedOptions type="array"> <numIndex index="0">params</numIndex> <numIndex index="1">rel</numIndex> </allowedOptions> </appearance> </config> </TCEforms> </link_1> I'll continue testing :)-be (or possibly "+being")typoFeature-97159-NewTCATypeLink.rst:4wrong headline -
Susi Moog commented on patch set 10 03/14/22, 12:26
Migration tested with: <linkold_1> <TCEforms> <label>linkold1</label> <config> <type>input</type> <renderType>inputLink</renderType> <required>true</required> <size>55</size> <eval>trim,null</eval> <fieldControl> <linkPopup> <options> <title>Hannelore</title> <blindLinkFields>class,target,title</blindLinkFields> <blindLinkOptions>mail,folder,telephone</blindLinkOptions> </options> </linkPopup> </fieldControl> </config> </TCEforms> </linkold_1> works 👍 - adding all my example code just in case someone wants to test it, too - or maybe we should add a flex example to the rst ;) -
Oli Bartsch uploaded patch set 11 03/14/22, 12:57
-
Oli Bartsch commented on patch set 11 03/14/22, 13:06
Reply
Since FlexForm values are interpreted as strings, adding the string "false" is actually evaluated to boolean TRUE in the element. The value hast to be "0" in the FlexForm. The BrowserTitle confused me too. It's used for the buttons' title attribute and therefore displayed on hovering over the button. "rel" only works in CKeditor (RTE)Reply
DoneReply
DoneFeature-97159-NewTCATypeLink.rst:4ReplyDone -
core-ci voted on patch set 11 V +1 03/14/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24881
-
Benni Mack commented on patch set 11 03/14/22, 13:12
LinkElement.php:3should we adda ClassAliasMap in EXT:backend for this class name change? -
Susi Moog voted on patch set 11 V +1 03/14/22, 13:47
-
Oli Bartsch uploaded patch set 12 03/14/22, 14:45
-
core-ci voted on patch set 12 V -1 03/14/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24883
-
Oli Bartsch uploaded patch set 13 03/14/22, 15:06
-
core-ci voted on patch set 13 V +1 03/14/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24884
-
Benni Mack commented on patch set 13 V +1 CR +1 03/14/22, 15:22
LinkElement.php:3ReplyDone -
Susi Moog voted on patch set 13 V +1 CR +1 03/14/22, 15:23
-
Oli Bartsch voted on patch set 13 V +2 CR +2 03/14/22, 15:26
-
Oli Bartsch merged patch set 14 03/14/22, 15:26