Review main Merged

73866[FEATURE] Introduce TCA type "link"

Oli Bartsch CR +2 V +2 Expert +1002 −315 updated 03/14/22, 15:26

Commit message

In our process of using dedicated TCA types,
the new TCA type "link" is introduced and
replaces "renderType=link" of TCA type "input".

Notable changes to the previous "inputLink" behaviour:

- "linkPopup" fieldControl is now always used by the
  FormEngine element
- Corresponding fieldControl options are migrated
  to columns config
- The type now makes use of include lists instead of
  exclude lists
- The allowed link types are now evaluated in DataHandler
- "trim" is always done in DataHandler and FormEngine
- "max" is no longer evaluated
- "softref=typolink" is automatically set

As mentioned, the TCA type "link" uses include lists.
This also required to adjust the LinkPopup fieldControl,
as well as the Link Browser classes. The previously
used "blinkLink[Fields|Options]" options are still
supported in case the "LinkPopup" fieldControl is used
for another TCA type. However, they might be deprecated
soon.

Finally, the TSconfig key for the MailLinkHandler is
renamed from "mail" to "email", to unify the naming
in the codebase.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 45

Show 25 more files

Review log 2438

Show 613 earlier messages
  1. Oli Bartsch uploaded patch set 1 03/09/22, 22:01

  2. core-ci voted on patch set 1 V -1 03/09/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24776

  3. Oli Bartsch uploaded patch set 2 03/10/22, 15:27

  4. core-ci voted on patch set 2 V -1 03/10/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24800

  5. Oli Bartsch uploaded patch set 3 03/10/22, 15:51

  6. core-ci voted on patch set 3 V -1 03/10/22, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24804

  7. Oli Bartsch uploaded patch set 4 03/10/22, 23:58

  8. core-ci voted on patch set 4 V -1 03/11/22, 00:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24822

  9. Oli Bartsch uploaded patch set 5 03/11/22, 09:59

  10. core-ci voted on patch set 5 V -1 03/11/22, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24831

  11. core-ci voted on patch set 5 V +1 03/11/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24831

  12. Oli Bartsch uploaded patch set 6 03/11/22, 14:46

  13. core-ci voted on patch set 6 V +1 03/11/22, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24834

  1. Oli Bartsch uploaded patch set 7 03/11/22, 16:27

  2. core-ci voted on patch set 7 V +1 03/11/22, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24836

  3. Oli Bartsch uploaded patch set 8 03/11/22, 18:09

  4. Oli Bartsch updated the commit message in patch set 9 03/11/22, 18:15

  5. core-ci voted on patch set 8 V -1 03/11/22, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24837

  6. core-ci voted on patch set 9 V +1 03/11/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24838

  7. Benni Mack voted on patch set 9 V +1 CR +1 03/11/22, 18:44

  8. Oli Bartsch uploaded patch set 10 03/11/22, 20:23

  9. core-ci voted on patch set 10 V +1 03/11/22, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24841

  10. Benni Mack voted on patch set 10 V +1 CR +1 03/12/22, 20:40

  11. Susi Moog commented on patch set 10 V -1 03/14/22, 12:19

    did some basic testing - in general +1, however in flexform context some appearance related options don't seem to work or I'm doing something wrong - I tried to adapt the rst example, disabling the browser did have no effect, browserTitle is not displayed (or I don't know where that is displayed) and no field for "rel" is displayed, however, allowedFileExtensions works: <link_1> <TCEforms> <label>link1</label> <config> <type>link</type> <required>true</required> <size>55</size> <allowedTypes type="array"> <numIndex index="0">page</numIndex> <numIndex index="1">url</numIndex> <numIndex index="2">record</numIndex> <numIndex index="3">file</numIndex> </allowedTypes> <appearance> <enableBrowser>false</enableBrowser> <browserTitle>Hannelore</browserTitle> <allowedFileExtensions type="array"> <numIndex index="0">jpg</numIndex> <numIndex index="1">png</numIndex> </allowedFileExtensions> <allowedOptions type="array"> <numIndex index="0">params</numIndex> <numIndex index="1">rel</numIndex> </allowedOptions> </appearance> </config> </TCEforms> </link_1> I'll continue testing :)
    -be (or possibly "+being")
    typo

    Feature-97159-NewTCATypeLink.rst:4

    wrong headline
  12. Susi Moog commented on patch set 10 03/14/22, 12:26

    Migration tested with: <linkold_1> <TCEforms> <label>linkold1</label> <config> <type>input</type> <renderType>inputLink</renderType> <required>true</required> <size>55</size> <eval>trim,null</eval> <fieldControl> <linkPopup> <options> <title>Hannelore</title> <blindLinkFields>class,target,title</blindLinkFields> <blindLinkOptions>mail,folder,telephone</blindLinkOptions> </options> </linkPopup> </fieldControl> </config> </TCEforms> </linkold_1> works 👍 - adding all my example code just in case someone wants to test it, too - or maybe we should add a flex example to the rst ;)
  13. Oli Bartsch uploaded patch set 11 03/14/22, 12:57

  14. Oli Bartsch commented on patch set 11 03/14/22, 13:06

    Reply

    Since FlexForm values are interpreted as strings, adding the string "false" is actually evaluated to boolean TRUE in the element. The value hast to be "0" in the FlexForm. The BrowserTitle confused me too. It's used for the buttons' title attribute and therefore displayed on hovering over the button. "rel" only works in CKeditor (RTE)

    Reply

    Done

    Reply

    Done

    Feature-97159-NewTCATypeLink.rst:4 Reply

    Done
  15. core-ci voted on patch set 11 V +1 03/14/22, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24881

  16. Benni Mack commented on patch set 11 03/14/22, 13:12

    LinkElement.php:3

    should we adda ClassAliasMap in EXT:backend for this class name change?
  17. Susi Moog voted on patch set 11 V +1 03/14/22, 13:47

  18. Oli Bartsch uploaded patch set 12 03/14/22, 14:45

  19. core-ci voted on patch set 12 V -1 03/14/22, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24883

  20. Oli Bartsch uploaded patch set 13 03/14/22, 15:06

  21. core-ci voted on patch set 13 V +1 03/14/22, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24884

  22. Benni Mack commented on patch set 13 V +1 CR +1 03/14/22, 15:22

    LinkElement.php:3 Reply

    Done
  23. Susi Moog voted on patch set 13 V +1 CR +1 03/14/22, 15:23

  24. Oli Bartsch voted on patch set 13 V +2 CR +2 03/14/22, 15:26

  25. Oli Bartsch merged patch set 14 03/14/22, 15:26