Review main Merged

73869[TASK] Simplify logic for Backend Router usages

Benni Mack CR +2 V +2 Normal +28 −47 updated 03/10/22, 19:47

Commit message

The Backend Router (introduced in TYPO3 v7)
is based on Symfony Routing and its Routing Components.

Some areas were exposed directly, which has
now been simplified to provide more functionality,
making DI etc. easier.

The improvements are rather important for
TYPO3 Core than to the outside world, where
the Router does not need to be used (instead, people
use UriBuilder for generating URLs), so the
new methods are not considered a new Feature.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 45

  1. Benni Mack uploaded patch set 1 03/10/22, 12:44

  2. core-ci voted on patch set 1 V +1 03/10/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24791

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 03/10/22, 16:42

  4. Georg Ringer voted on patch set 1 V +2 CR +2 03/10/22, 19:47

  5. Georg Ringer merged patch set 2 03/10/22, 19:47