Review main Merged

73870[TASK] Update to PHPStan 1.4.9

Oliver Klee CR +2 V +2 Easy +8 −13 updated 03/10/22, 16:47

Commit message

This update gets rid of a false positive:

https://github.com/phpstan/phpstan-phpunit/issues/120

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Oliver Klee uploaded patch set 1 03/10/22, 13:16

  2. Oliver Klee updated the commit message in patch set 2 03/10/22, 13:17

  3. Oliver Klee updated the commit message in patch set 3 03/10/22, 13:17

  4. core-ci voted on patch set 1 V +1 03/10/22, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24793

  5. core-ci voted on patch set 2 V +1 03/10/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24794

  6. core-ci voted on patch set 3 V +1 03/10/22, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24795

  7. Benni Mack voted on patch set 3 V +1 CR +1 03/10/22, 16:39

  8. Oli Bartsch voted on patch set 3 V +2 CR +2 03/10/22, 16:47

  9. Oli Bartsch merged patch set 4 03/10/22, 16:47