Review 11.5 Merged

73879[BUGFIX] Avoid undefined array key warnings in PreviewUriBuilder

Benni Mack CR +2 V +2 Easy +3 −3 updated 03/14/22, 13:18

Commit message

In class \TYPO3\CMS\Workspaces\Preview\PreviewUriBuilder the value
for TSconfig option "options.workspaces.previewPageId" is tested for a
syntax like field:value but if the actual value does not use a colon,
it will result in an undefined array key warning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 03/14/22, 12:44

    Cherry Picked from branch main.
  2. Oliver Klee voted on patch set 1 CR +1 03/14/22, 12:51

  3. core-ci voted on patch set 1 V +1 03/14/22, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24879

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/14/22, 13:18

  5. Benni Mack merged patch set 2 03/14/22, 13:18