Review main Merged

73894[TASK] Remove superfluous variables from FormEngine elements

Oli Bartsch CR +2 V +2 Easy +19 −29 updated 03/15/22, 08:15

Commit message

$disabled is initialized as empty string and never
updated, before being added to the markup, thus
has no effect.

$placeholder is initialized with "0" and never updated,
thus the value can be set in the markup directly.

Additionally, this replaces a strlen() check with an empty
string comparison.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Oli Bartsch uploaded patch set 1 03/10/22, 16:05

  2. core-ci voted on patch set 1 V +1 03/10/22, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24805

  3. Oli Bartsch uploaded patch set 2 03/14/22, 15:41

  4. core-ci voted on patch set 2 V +1 03/14/22, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24886

  5. Benni Mack voted on patch set 2 V +1 CR +1 03/14/22, 17:08

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 03/14/22, 19:08

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 03/15/22, 08:15

  8. Oli Bartsch merged patch set 3 03/15/22, 08:15