Review main Merged

73897[BUGFIX] Add record title of content in InternalLinkType

Oli Bartsch CR +2 V +2 Easy +5 −3 updated 03/15/22, 09:08

Commit message

In case an internal link targets a content element,
defined by an anchor, this element is checked for
e.g. being moved, hidden or deleted.

In case the element is moved the "title" attribute
was not filled, leading to a PHP warning.

This is now fixed by always adding the correct
record title.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 03/10/22, 18:10

  2. Oli Bartsch uploaded patch set 2 03/10/22, 18:15

  3. core-ci voted on patch set 1 V +1 03/10/22, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24817

  4. core-ci voted on patch set 2 V +1 03/10/22, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24818

  5. Benni Mack voted on patch set 2 V +1 CR +1 03/14/22, 15:18

  6. Jochen Roth voted on patch set 2 V +1 CR +1 03/15/22, 08:37

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 03/15/22, 09:08

  8. Oli Bartsch merged patch set 3 03/15/22, 09:08