73900[BUGFIX] Enable generic backend preview in workspaces
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 3
Review log 2433
Show 68 earlier messages
-
Francois Suter uploaded patch set 1 03/11/22, 08:32
-
core-ci voted on patch set 1 V -1 03/11/22, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24828
-
Francois Suter commented on patch set 1 03/11/22, 09:32
Note sure what is failing... But note to self: if the record is new in a workspace, it will have no live counterpart. This is untested for now. -
Torben Hansen commented on patch set 1 03/11/22, 09:35
Reply
Pre-merge CGL test is failing (missing comma) - see https://git.typo3.org/typo3/CI/cms/-/jobs/1135290 -
Francois Suter commented on patch set 1 03/11/22, 09:45
Ah great, thanks for the pointer. -
Francois Suter uploaded patch set 2 03/11/22, 09:57
-
Francois Suter commented on patch set 2 03/11/22, 09:57
Reply
Done -
core-ci voted on patch set 2 V +1 03/11/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24829
-
Francois Suter uploaded patch set 3 03/21/22, 11:32
-
Francois Suter commented on patch set 3 03/21/22, 11:35
Patchset 3 resolves 2 pending issues: * the patch is rebased and thus includes the smaller bug fix this larger patch required * I'm using \TYPO3\CMS\Core\Utility\GeneralUtility::removeDotsFromTS() instead of the method copied from BackendUtility, so there's no code redundancy anymore The other questions remains open, including deciding whether this is really a bugfix or is actually a feature. -
core-ci voted on patch set 3 V +1 03/21/22, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25015
-
Benni Mack commented on patch set 3 03/21/22, 21:07
Patch looks OK, Francois -
Francois Suter uploaded patch set 4
V +101/27/23, 11:08 -
Francois Suter updated the commit message in patch set 5 01/27/23, 11:09
-
core-ci voted on patch set 4 V -1 01/27/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36689
-
Francois Suter uploaded patch set 6 01/27/23, 11:18
-
core-ci voted on patch set 5 V -1 01/27/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36690
-
core-ci voted on patch set 6 V +1 01/27/23, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36691
-
Francois Suter updated the commit message in patch set 7
V +101/27/23, 11:35 -
core-ci voted on patch set 7 V +1 01/27/23, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36692
-
Benni Mack commented on patch set 7 01/27/23, 14:33
Thank you very much, Francois. I think I would clarify this as a bugfix, not a feature. -
Francois Suter updated the commit message in patch set 8
V +101/27/23, 15:12 -
Francois Suter commented on patch set 8 01/27/23, 15:13
Reply
OK, I have changed the topic back to bug fix. -
core-ci voted on patch set 8 V +1 01/27/23, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36701
-
Benni Mack commented on patch set 8 02/05/23, 23:08
about your WIP comments in the commit message, I think they are reasonable and I think this is totally legit to use it like this -
Francois Suter uploaded patch set 9
V +102/10/23, 10:53 -
Francois Suter commented on patch set 9 02/10/23, 10:54
Reply
Thanks for your validation. I have removed the WIP status and added a note in the workspaces documentation about preview page id definition overlap. -
core-ci voted on patch set 9 V +1 02/10/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37543
-
Benni Mack voted on patch set 9 CR +1 02/10/23, 11:30
-
Christian Kuhn voted on patch set 9 V +1 CR +1 02/13/23, 09:51
-
Christian Kuhn voted on patch set 9 V +2 CR +2 02/13/23, 09:53
-
Christian Kuhn merged patch set 10 02/13/23, 09:53
-
Francois Suter commented on patch set 10 02/13/23, 10:53
Thanks a lot for taking care!