Review main Merged

73900[BUGFIX] Enable generic backend preview in workspaces

Francois Suter CR +2 V +2 Easy +37 −5 updated 02/13/23, 10:53

Commit message

The TYPO3 backend offers a generic preview mechanism for any type
of record. The configuration includes being able to pass needed
parameters to some kind of plugin/controller.

The workspaces also offer a preview feature, but do not take the
backend preview configuration into account in the Workspaces
module.

See the Forge ticket for more explanations and test setup.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 2433

Show 68 earlier messages
  1. Francois Suter uploaded patch set 1 03/11/22, 08:32

  2. core-ci voted on patch set 1 V -1 03/11/22, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24828

  3. Francois Suter commented on patch set 1 03/11/22, 09:32

    Note sure what is failing... But note to self: if the record is new in a workspace, it will have no live counterpart. This is untested for now.
  4. Torben Hansen commented on patch set 1 03/11/22, 09:35

    Reply

    Pre-merge CGL test is failing (missing comma) - see https://git.typo3.org/typo3/CI/cms/-/jobs/1135290
  5. Francois Suter commented on patch set 1 03/11/22, 09:45

    Ah great, thanks for the pointer.
  6. Francois Suter uploaded patch set 2 03/11/22, 09:57

  7. Francois Suter commented on patch set 2 03/11/22, 09:57

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 03/11/22, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24829

  1. Francois Suter uploaded patch set 3 03/21/22, 11:32

  2. Francois Suter commented on patch set 3 03/21/22, 11:35

    Patchset 3 resolves 2 pending issues: * the patch is rebased and thus includes the smaller bug fix this larger patch required * I'm using \TYPO3\CMS\Core\Utility\GeneralUtility::removeDotsFromTS() instead of the method copied from BackendUtility, so there's no code redundancy anymore The other questions remains open, including deciding whether this is really a bugfix or is actually a feature.
  3. core-ci voted on patch set 3 V +1 03/21/22, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25015

  4. Benni Mack commented on patch set 3 03/21/22, 21:07

    Patch looks OK, Francois
  5. Francois Suter uploaded patch set 4 V +1 01/27/23, 11:08

  6. Francois Suter updated the commit message in patch set 5 01/27/23, 11:09

  7. core-ci voted on patch set 4 V -1 01/27/23, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36689

  8. Francois Suter uploaded patch set 6 01/27/23, 11:18

  9. core-ci voted on patch set 5 V -1 01/27/23, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36690

  10. core-ci voted on patch set 6 V +1 01/27/23, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36691

  11. Francois Suter updated the commit message in patch set 7 V +1 01/27/23, 11:35

  12. core-ci voted on patch set 7 V +1 01/27/23, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36692

  13. Benni Mack commented on patch set 7 01/27/23, 14:33

    Thank you very much, Francois. I think I would clarify this as a bugfix, not a feature.
  14. Francois Suter updated the commit message in patch set 8 V +1 01/27/23, 15:12

  15. Francois Suter commented on patch set 8 01/27/23, 15:13

    Reply

    OK, I have changed the topic back to bug fix.
  16. core-ci voted on patch set 8 V +1 01/27/23, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36701

  17. Benni Mack commented on patch set 8 02/05/23, 23:08

    about your WIP comments in the commit message, I think they are reasonable and I think this is totally legit to use it like this
  18. Francois Suter uploaded patch set 9 V +1 02/10/23, 10:53

  19. Francois Suter commented on patch set 9 02/10/23, 10:54

    Reply

    Thanks for your validation. I have removed the WIP status and added a note in the workspaces documentation about preview page id definition overlap.
  20. core-ci voted on patch set 9 V +1 02/10/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37543

  21. Benni Mack voted on patch set 9 CR +1 02/10/23, 11:30

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 02/13/23, 09:51

  23. Christian Kuhn voted on patch set 9 V +2 CR +2 02/13/23, 09:53

  24. Christian Kuhn merged patch set 10 02/13/23, 09:53

  25. Francois Suter commented on patch set 10 02/13/23, 10:53

    Thanks a lot for taking care!