Review main Merged

73902[BUGFIX] Consider all relevant pids when populating BE TS constants

Susi Moog CR +2 V +2 Easy +12 −5 updated 03/21/22, 12:42

Commit message

The TemplateService - if no TSFE is available - uses the rootline
to find a matching site. Previously it only considered the top most
element of the root line for finding a site, now it also considers
all pages in the rootline with is_siteroot set.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Susi Moog uploaded patch set 1 03/11/22, 14:04

  2. Markus Klein voted on patch set 1 CR +1 03/11/22, 14:16

  3. core-ci voted on patch set 1 V +1 03/11/22, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24833

  4. Jörg Bösche voted on patch set 1 CR +1 03/11/22, 14:32

  5. Georg Ringer voted on patch set 1 V +1 CR +1 03/15/22, 22:36

  6. Benni Mack voted on patch set 1 V +2 CR +2 03/21/22, 12:42

  7. Benni Mack merged patch set 2 03/21/22, 12:42