73905[TASK] Move BE_USER check from TSFE into middleware
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+35 −76
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php3+16 −1
Review log 1521
-
Benni Mack uploaded patch set 1 03/12/22, 21:18
-
core-ci voted on patch set 1 V +1 03/12/22, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24850
-
Benni Mack updated the commit message in patch set 2 03/13/22, 16:21
-
Benni Mack updated the commit message in patch set 3 03/13/22, 16:21
-
core-ci voted on patch set 2 V +1 03/13/22, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24858
-
core-ci voted on patch set 3 V +1 03/13/22, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24859
-
Benni Mack commented on patch set 4 03/13/22, 20:29
Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 03/13/22, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24860
-
Susi Moog commented on patch set 4 03/14/22, 11:30
TypoScriptFrontendInitialization.php:119is there a reason why we cannot move this to the PreviewSimulator and just check the context (frontend.preview) here directly? -
Benni Mack commented on patch set 4 03/14/22, 11:33
TypoScriptFrontendInitialization.php:119Replynope. will try -
Benni Mack uploaded patch set 5 03/14/22, 11:38
-
Benni Mack commented on patch set 5 03/14/22, 11:39
TypoScriptFrontendInitialization.php:119ReplyDone -
core-ci voted on patch set 5 V +1 03/14/22, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24874
-
Susi Moog voted on patch set 5 CR +1 03/14/22, 12:34
-
Susi Moog voted on patch set 5 V +1 03/14/22, 12:47
-
Oli Bartsch uploaded patch set 6 03/14/22, 15:24
-
Oli Bartsch voted on patch set 6 V +1 CR +1 03/14/22, 15:24
-
Susi Moog voted on patch set 6 V +1 CR +1 03/14/22, 15:26
-
core-ci voted on patch set 6 V +1 03/14/22, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24885
-
Benni Mack voted on patch set 6 V +2 CR +2 03/14/22, 15:37
-
Benni Mack merged patch set 7 03/14/22, 15:37