Review main Merged

73906[TASK] Streamline drag uploader failure message

Benni Mack CR +2 V +2 Hard +154 −130 updated 03/28/22, 11:55

Commit message

The Folder Tree shows notifications through
FlashMessages when using the AJAX endpoint "file_process",
while the drag uploader still used the very old
"terr" XML Response (which I added in TYPO3 v4.1).

Now the file_process returns the error messages
from the flash message queue, ready to be printed
out.

The "includeMessages" is thus not needed anymore,
as message results are always sent.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1016

  1. Benni Mack uploaded patch set 1 03/14/22, 07:53

  2. Susi Moog voted on patch set 1 CR +1 03/14/22, 07:56

  3. Benni Mack uploaded patch set 2 03/14/22, 07:57

  4. core-ci voted on patch set 1 V -1 03/14/22, 08:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24864

  5. core-ci voted on patch set 2 V -1 03/14/22, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24866

  6. Benni Mack uploaded patch set 3 03/14/22, 09:13

  7. core-ci voted on patch set 3 V -1 03/14/22, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24869

  8. Benni Mack uploaded patch set 4 03/14/22, 19:03

  9. core-ci voted on patch set 4 V -1 03/14/22, 19:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24891

  10. Benni Mack uploaded patch set 5 03/24/22, 21:42

  11. core-ci voted on patch set 5 V -1 03/24/22, 22:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25117

  12. Oli Bartsch uploaded patch set 6 03/28/22, 10:54

  13. core-ci voted on patch set 6 V +1 03/28/22, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25207

  14. Oli Bartsch voted on patch set 6 V +1 CR +1 03/28/22, 11:12

  15. Christian Kuhn voted on patch set 6 V +2 CR +2 03/28/22, 11:55

  16. Christian Kuhn merged patch set 7 03/28/22, 11:55