Review main Merged

73907[TASK] Streamline AbstractUserAuthentication unpack_uc()

Benni Mack CR +2 V +2 Easy +8 −16 updated 03/14/22, 11:11

Commit message

The "uc" value of a FE User / BE User is now
moved in the right spot so it does not need
to be called explicitly anymore.

"uc" is now unpacked right before MFA is needed during
the login process, so MFA can access the "uc".

As "uc" is needed after group resolving, it is added
at the right place for all code places, making
it obsolete to be called in user-land code.

In addition the "uc" property "firstLoginTimeStamp"
is removed which was used for TYPO3 v4.3 to show
a donation banner, which was removed again years ago.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Gorges +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Benni Mack uploaded patch set 1 03/14/22, 08:04

  2. core-ci voted on patch set 1 V +1 03/14/22, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24867

  3. Oli Bartsch uploaded patch set 2 03/14/22, 08:54

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 03/14/22, 08:54

  5. core-ci voted on patch set 2 V +1 03/14/22, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24868

  6. Daniel Gorges voted on patch set 2 V +1 CR +1 03/14/22, 11:10

  7. Benni Mack voted on patch set 2 V +2 CR +2 03/14/22, 11:11

  8. Benni Mack merged patch set 3 03/14/22, 11:11