73913[TASK] Update HTML Sanitizer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- crell +1
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1518
-
crell uploaded patch set 1 03/14/22, 20:38
-
core-ci voted on patch set 1 V +1 03/14/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24892
-
Oliver Klee voted on patch set 1 CR +1 03/14/22, 23:17
-
Simon Schaufelberger voted on patch set 1 V +1 CR +1 03/15/22, 00:30
-
Benjamin Franzke commented on patch set 1 CR -1 03/15/22, 05:19
Please also backport to v11 (add an appropriate Releases line), or is there a reason not to backport? -
crell commented on patch set 1 03/15/22, 19:58
Reply
I think the only change from v1.0.13 to .14 was changing the psr/log versions. The v2 and v3 versions require PHP 8.x anyway, though, so that part isn't backportable to v11 anyway. So, at least for the scope I have in mind there's no reason to backport. (There may be other reasons, but they're separate from my intent here.) -
Stefan Bürk commented on patch set 1 CR -1 03/16/22, 14:35
Reply
v11 also uses "^2.0.11" .. and "https://packagist.org/packages/typo3/html-sanitizer":"^2.0.14" is php:"^7.2 || ^8.0". So I'm here with Benjamin, we should add the backport for it. to have a similar min version constraint which is possible in this case. See: https://packagist.org/packages/typo3/html-sanitizer -
Stefan Bürk updated the commit message in patch set 2 03/16/22, 14:35
-
Oliver Klee voted on patch set 2 CR +1 03/16/22, 14:42
-
core-ci voted on patch set 2 V -1 03/16/22, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24947
-
core-ci voted on patch set 2 V +1 03/16/22, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24947
-
Stefan Bürk voted on patch set 2 V +1 CR +1 03/16/22, 15:00
-
crell voted on patch set 2 CR +1 03/16/22, 19:57
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 03/17/22, 18:18
-
Oli Bartsch voted on patch set 2 V +1 CR +1 03/17/22, 21:46
-
Benni Mack voted on patch set 2 V +2 CR +2 03/21/22, 12:00
-
Benni Mack merged patch set 3 03/21/22, 12:00
-
Christian Kuhn commented on patch set 3 11/20/22, 14:37
merged to v11 with https://review.typo3.org/c/Packages/TYPO3.CMS/+/73997