Review main Merged

73914[BUGFIX] Make full module information available

Oli Bartsch CR +2 V +2 Normal +56 −9 updated 03/22/22, 22:10

Commit message

A couple of JS modules requires some module
information, such as the navigationComponent.

Those information were previously added as data
attributes to the main module menu items and then
retrieved by the JS components. This however did no longer
work for third-level modules, introduced in #97135,
since they are not present in the main module menu.

This is now resolved by adding the full module information,
including all modules, as a single data attribute to the
"scaffold-modulemenu" element.

Note: On installing new extensions, which add backend
modules, a complete backend refresh is necessary for
the new modules to be accessible. An automatic refresh will
be added in another patch, since this will also be
required to update the JavaScript import maps.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 914

  1. Oli Bartsch uploaded patch set 1 03/14/22, 22:01

  2. core-ci voted on patch set 1 V -1 03/14/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24893

  3. Oli Bartsch uploaded patch set 2 03/14/22, 22:14

  4. core-ci voted on patch set 2 V +1 03/14/22, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24894

  5. Simon Schaufelberger updated the commit message in patch set 3 03/14/22, 23:54

  6. core-ci voted on patch set 3 V +1 03/15/22, 00:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24897

  7. Oli Bartsch uploaded patch set 4 03/16/22, 16:17

  8. core-ci voted on patch set 4 V +1 03/16/22, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24948

  9. Benjamin Franzke uploaded patch set 5 03/22/22, 20:39

  10. core-ci voted on patch set 5 V +1 03/22/22, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25057

  11. Benni Mack voted on patch set 5 V +1 CR +1 03/22/22, 22:02

  12. Oli Bartsch voted on patch set 5 V +2 CR +2 03/22/22, 22:10

  13. Oli Bartsch merged patch set 6 03/22/22, 22:10

  14. Stefan Bürk voted on patch set 5 V +1 CR +1 03/22/22, 22:10